From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UWoyo-0003sV-RF
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 10:23:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UWoyn-0000iU-OA
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 10:22:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42055)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UWoyn-0000iP-H7
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 10:22:57 -0400
Message-ID: <517E8232.5020202@redhat.com>
Date: Mon, 29 Apr 2013 16:22:42 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367172276-23293-1-git-send-email-riegamaths@gmail.com>
	<517E2D17.4020401@redhat.com>
	<CAOZVR5ZyrU3asoL_QPzYKOqGxb6FiENu=XGhTFtcgW-pC44gpA@mail.gmail.com>
In-Reply-To: <CAOZVR5ZyrU3asoL_QPzYKOqGxb6FiENu=XGhTFtcgW-pC44gpA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix build breakage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dunrong Huang <riegamaths@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel <qemu-devel@nongnu.org>

Il 29/04/2013 15:33, Dunrong Huang ha scritto:
> 
> Yes,  this way works for me.
> 
> diff --git a/rules.mak b/rules.mak
> index 292a422..2572070 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -15,7 +15,7 @@ MAKEFLAGS += -rR
>  QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>  
>  # Same as -I$(SRC_PATH) -I., but for the nested source/object directories
> -QEMU_CFLAGS += -I$(<D) -I$(@D)
> +QEMU_INCLUDES += -I$(<D) -I$(@D)
> 
> but I don't know if it will break other build, e.g. mingw build.

Please submit it, it is a better fix.  Make sure you put "1.5" in the
subject.

Paolo