From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UWqAa-0006aR-9r
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 11:39:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UWqAZ-00013O-0s
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 11:39:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UWqAY-00011i-82
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 11:39:10 -0400
Message-ID: <517E940D.2080704@redhat.com>
Date: Mon, 29 Apr 2013 17:38:53 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367247132-19622-1-git-send-email-riegamaths@gmail.com>
In-Reply-To: <1367247132-19622-1-git-send-email-riegamaths@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.5 v2] rules.mk: Fix build breakage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dunrong Huang <riegamaths@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel <qemu-devel@nongnu.org>

Il 29/04/2013 16:52, Dunrong Huang ha scritto:
> The following error occurs when building dtc module:
> 
>         CHK version_gen.h
>          CC libfdt/fdt.o
> cc1: error: dtc: No such file or directory [-Werror]
> cc1: all warnings being treated as errors
> make[1]: *** [libfdt/fdt.o] Error 1
> make: *** [subdir-dtc] Error 2
> 
> In rules.mak, "-I$(<D) -I$(@D)" was expanded to "-Idtc -I." when
> building submodule dct. Due to the using of "-Wmissing-include-dirs,
> a warning would be rarsed. To avoid it, add "-I$(<D) -I$(@D)" to
> QEMU_INCLUDES instead of QEMU_CFLAGS so that QEMU_CFLAGS does not
> contain the "-Idtc".
> 
> Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Dunrong Huang <riegamaths@gmail.com>
> ---
> v1 -> v2:
>    * Fix it by adding "-I$(<D) -I$(@D)" to QEMU_INCLUDES instead of
>      QEMU_CFLAGS(thanks to Paolo Bonzini for correction)
>    
>  rules.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules.mak b/rules.mak
> index 292a422..2572070 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -15,7 +15,7 @@ MAKEFLAGS += -rR
>  QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>  
>  # Same as -I$(SRC_PATH) -I., but for the nested source/object directories
> -QEMU_CFLAGS += -I$(<D) -I$(@D)
> +QEMU_INCLUDES += -I$(<D) -I$(@D)
>  
>  %.o: %.c
>  	$(call quiet-command,$(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>