From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrVV-0004ld-PR for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:04:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWrVU-0005T8-Gv for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:04:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56218 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrVU-0005Su-9q for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:04:52 -0400 Message-ID: <517EA833.4010600@suse.de> Date: Mon, 29 Apr 2013 19:04:51 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1367247776-7695-3-git-send-email-imammedo@redhat.com> <1367254453-25800-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1367254453-25800-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/7 v8] target-i386: Attach ICC bus to CPU on its creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, ehabkost@redhat.com Am 29.04.2013 18:54, schrieb Igor Mammedov: > X86CPU should have parent bus so it could provide bus for child APIC. >=20 > Signed-off-by: Igor Mammedov > Signed-off-by: Andreas F=C3=A4rber > --- > TODO: fix unplug of bus-less devices in device-del >=20 > v3: > - check icc_bridge for NULL and report error nicely instead of SIGSEG= V > v2: > - pass icc_bridge to cpu_x86_create instead of resolving it each time > --- > hw/i386/pc.c | 10 ++++++---- > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 2 +- > include/hw/i386/pc.h | 2 +- > target-i386/cpu.c | 15 +++++++++++++-- > target-i386/cpu.h | 3 ++- > 6 files changed, 24 insertions(+), 10 deletions(-) Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg