From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrqK-0003bQ-6z for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWrqJ-00048l-25 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:26:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57082 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrqI-00048h-Sy for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:26:23 -0400 Message-ID: <517EAD3D.5070703@suse.de> Date: Mon, 29 Apr 2013 19:26:21 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366303444-24620-1-git-send-email-pbonzini@redhat.com> <1366303444-24620-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1366303444-24620-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/8] adlib: qdev-ify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: av1474@comtv.ru, qemu-devel@nongnu.org Am 18.04.2013 18:43, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > RFC->v1: follow QOM guidelines (Andreas) >=20 > hw/audio/adlib.c | 83 ++++++++++++++++++++++++++++++++++++++++++++----= -------- > 1 file changed, 66 insertions(+), 17 deletions(-) Thanks, Reviewed-by: Andreas F=E4rber At some point we should unify all the naming conventions of when, where or whether we use fn but no last-minute respins sensible for that. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg