Re: [Qemu-devel] [PATCH] memory: give name every AddressSpace

[Alexey Kardashevskiy <aik@ozlabs.ru>]

On 04/29/2013 07:25 PM, Paolo Bonzini wrote:
> Il 29/04/2013 10:21, Alexey Kardashevskiy ha scritto:
>>>>>> +    g_free((void *)as->name);
>>>>
>>>> No cast here.
>> ?
>>
>>   CC    ppc64-softmmu/memory.o
>> /home/alexey/pcipassthru/qemu-impreza/memory.c: In function
>> 'address_space_destroy':
>> /home/alexey/pcipassthru/qemu-impreza/memory.c:1626:5: warning: passing
>> argument 1 of 'g_free' discards 'const' qualifier from pointer target type
>> [enabled by default]
>>      g_free(/*(void *)*/as->name);
>>      ^
> 
> Please remove the const from as->name instead.  Since you are strdup-ing
> it, and the field is meant to be private to memory.c anyway, you do not
> need protection against changing it.

ok, no prob, I'll repost the patch.

In meanwhile, could you please update docs/memory.txt and include
AddressSpace and MemoryListener things in it as it is not absolutely clear
what is what and for what purpose? The current version of the doc is too
old. Thanks.



-- 
Alexey