qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jordan Justen <jljusten@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0
Date: Tue, 30 Apr 2013 09:24:23 +0200	[thread overview]
Message-ID: <517F71A7.10303@redhat.com> (raw)
In-Reply-To: <CAFe8ug-QmV0PsmjkLXa1w-wC9SghNNQ4dm098Op0OBCFPQy7Ew@mail.gmail.com>

Il 30/04/2013 05:51, Jordan Justen ha scritto:
> The rom in qemu is read-only. In kvm, it has been read-write. That is
> different behavior.

And it was a problem, hence it was reverted.

> I assume with kvm readonly support, at some point the rom may be
> read-only or read/write under kvm depending on the capabilities.

No, this would be bad.

> Anyway, would this work:
> if (-pflash is not used) {
>   qemu and kvm always use a 'rom' mode
> } else if (non-kvm or kvm read-only capable) {
>   PC flash used
> } else {
>   die "kvm+pflash requires read-only capability"
> }
> 
> Someone could create a flash capable VM on qemu or newer kvm, and then
> have trouble with it on an older kvm, but the chance of potential
> issues seems greatly reduced.
> 
> For people using rom firmware, this should have no impact.

Yes, _this_ would work because it requires a special command line, and
it would have never worked before.

Paolo

  reply	other threads:[~2013-04-30  7:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-28  8:32 [Qemu-devel] [PATCH 0/6] KVM flash memory support Jordan Justen
2013-04-28  8:32 ` [Qemu-devel] [PATCH 1/6] kvm: add kvm_readonly_mem_enabled Jordan Justen
2013-04-29 10:27   ` Jan Kiszka
2013-04-28  8:32 ` [Qemu-devel] [PATCH 2/6] kvm: support using KVM_MEM_READONLY flag for readonly regions Jordan Justen
2013-05-03  6:02   ` Xiao Guangrong
2013-04-28  8:32 ` [Qemu-devel] [PATCH 3/6] kvm: workaround a possible KVM bug when using KVM_MEM_READONLY Jordan Justen
2013-04-29 10:29   ` Jan Kiszka
2013-04-29 18:37     ` Jordan Justen
2013-05-03  6:13   ` Xiao Guangrong
2013-04-28  8:32 ` [Qemu-devel] [PATCH 4/6] pflash_cfi01: memory region should be set to enable readonly mode Jordan Justen
2013-04-28  8:32 ` [Qemu-devel] [PATCH 5/6] pc_sysfw: allow flash memory to be used with KVM Jordan Justen
2013-04-28  8:32 ` [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0 Jordan Justen
2013-04-29  8:20   ` Paolo Bonzini
2013-04-29 18:23     ` Jordan Justen
2013-04-29 21:10       ` Paolo Bonzini
2013-04-30  3:51         ` Jordan Justen
2013-04-30  7:24           ` Paolo Bonzini [this message]
2013-04-29 14:00   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517F71A7.10303@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jljusten@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).