Re: [Qemu-devel] [Qemu-stable] Something broken with ceph-rbd images since couple of days ( after block-changes)

Re: [Qemu-devel] [Qemu-stable] Something broken with ceph-rbd images since couple of days ( after block-changes)

[Kevin Wolf]

Am 25.04.2013 um 19:25 hat Stefan Priebe - Profihost AG geschrieben:
> Ist this qemu 1.4.1? Did you received the patch?
> 
> Stefan

No, this is actually about git master. Not sure why this was directed to
qemu-stable.

Kevin

> Am 25.04.2013 um 16:13 schrieb Oliver Francke <Oliver.Francke@filoo.de>:
> 
> > Cool,
> > 
> > thnx for the quick response... Not a C-coder any more, only wild-not-too-bad guessing ;)
> > 
> > Oliver.
> > 
> > On 04/25/2013 03:51 PM, Kevin Wolf wrote:
> >> Am 25.04.2013 um 15:01 hat Oliver Francke geschrieben:
> >>> Hi,
> >>> 
> >>> just encountered a bug while playing with latest aio_flush option in
> >>> ceph + qemu handling.
> >>> 
> >>> I got a "invalid argument" even with "qemu-img info rbd:pool/image.rbd".
> >>> 
> >>> Perhaps qemu_rbd_open is called with wrong number of params
> >>> somewhere else after expanding params with "QDict *options" in
> >>> block/rbd.c line around line 444 with current master.
> >>> ( talking of qemu-54f106d)
> >>> 
> >>> Just as a quick note ;)
> >> Thanks for the report, Oliver. The problem is the qemu_opts_del() in
> >> line 481, which is too early. This frees the filename already when it's
> >> still needed for the parsing.
> >> 
> >> I'm copying qemu-devel and Josh, just so everyone is informed. I'll try
> >> to send a patch myself in a few minutes.
> >> 
> >> Kevin
> > 
> > 
> > -- 
> > 
> > Oliver Francke
> > 
> > filoo GmbH
> > Moltkestraße 25a
> > 33330 Gütersloh
> > HRB4355 AG Gütersloh
> > 
> > Geschäftsführer: S.Grewing | J.Rehpöhler | C.Kunz
> > 
> > Folgen Sie uns auf Twitter: http://twitter.com/filoogmbh
> > 
> > 

Re: [Qemu-devel] [Qemu-stable] Something broken with ceph-rbd images since couple of days ( after block-changes)

[Oliver Francke]

Hi,

took a snapshot of yesterdays "master" after "rbd: Fix use after free in 
rbd_open()"... Works perfectly ;)

Thank you very much for the bleeding fast reaction...

Oliver.

On 04/25/2013 07:32 PM, Kevin Wolf wrote:
> Am 25.04.2013 um 19:25 hat Stefan Priebe - Profihost AG geschrieben:
>> Ist this qemu 1.4.1? Did you received the patch?
>>
>> Stefan
> No, this is actually about git master. Not sure why this was directed to
> qemu-stable.
>
> Kevin
>
>> Am 25.04.2013 um 16:13 schrieb Oliver Francke <Oliver.Francke@filoo.de>:
>>
>>> Cool,
>>>
>>> thnx for the quick response... Not a C-coder any more, only wild-not-too-bad guessing ;)
>>>
>>> Oliver.
>>>
>>> On 04/25/2013 03:51 PM, Kevin Wolf wrote:
>>>> Am 25.04.2013 um 15:01 hat Oliver Francke geschrieben:
>>>>> Hi,
>>>>>
>>>>> just encountered a bug while playing with latest aio_flush option in
>>>>> ceph + qemu handling.
>>>>>
>>>>> I got a "invalid argument" even with "qemu-img info rbd:pool/image.rbd".
>>>>>
>>>>> Perhaps qemu_rbd_open is called with wrong number of params
>>>>> somewhere else after expanding params with "QDict *options" in
>>>>> block/rbd.c line around line 444 with current master.
>>>>> ( talking of qemu-54f106d)
>>>>>
>>>>> Just as a quick note ;)
>>>> Thanks for the report, Oliver. The problem is the qemu_opts_del() in
>>>> line 481, which is too early. This frees the filename already when it's
>>>> still needed for the parsing.
>>>>
>>>> I'm copying qemu-devel and Josh, just so everyone is informed. I'll try
>>>> to send a patch myself in a few minutes.
>>>>
>>>> Kevin
>>>
>>> -- 
>>>
>>> Oliver Francke
>>>
>>> filoo GmbH
>>> Moltkestraße 25a
>>> 33330 Gütersloh
>>> HRB4355 AG Gütersloh
>>>
>>> Geschäftsführer: S.Grewing | J.Rehpöhler | C.Kunz
>>>
>>> Folgen Sie uns auf Twitter: http://twitter.com/filoogmbh
>>>
>>>


-- 

Oliver Francke

filoo GmbH
Moltkestraße 25a
33330 Gütersloh
HRB4355 AG Gütersloh

Geschäftsführer: S.Grewing | J.Rehpöhler | C.Kunz

Folgen Sie uns auf Twitter: http://twitter.com/filoogmbh