From: Peter Krempa <pkrempa@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, libvir-list@redhat.com,
qemu-devel@nongnu.org, pbonzini@redhat.com,
Igor Mammedov <imammedo@redhat.com>,
afaerber@suse.de
Subject: Re: [Qemu-devel] [libvirt] [PATCH 2/4] QMP: add cpu-add command
Date: Tue, 30 Apr 2013 15:53:56 +0200 [thread overview]
Message-ID: <517FCCF4.4020906@redhat.com> (raw)
In-Reply-To: <20130430134620.GB28606@otherpad.lan.raisama.net>
On 04/30/13 15:46, Eduardo Habkost wrote:
> (CCing libvir-list)
>
> On Tue, Apr 30, 2013 at 08:34:01AM +0200, Igor Mammedov wrote:
>> Adds "cpu-add id=xxx" QMP command.
>>
>> cpu-add's "id" argument is a CPU number in a range [0..max-cpus)
>>
>> Example QMP command:
>> -> { "execute": "cpu-add", "arguments": { "id": 2 } }
>> <- { "return": {} }
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> The only way to find out if CPU hotplug is really available on a given
> machine-type is by actually trying to run cpu-add, right? Is this
> sufficient for libvirt requirements?
>
>
As long as the command fails when it's not supported it's okay.
(cpu_set HMP command does not fail when offlining a cpu even if it isn't
supported and that's real pain to use)
Peter
next prev parent reply other threads:[~2013-04-30 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 6:33 [Qemu-devel] [PATCH 0/4 v8 for-1.5] target-i386: CPU hot-add with cpu-add QMP command Igor Mammedov
2013-04-30 6:34 ` [Qemu-devel] [PATCH 1/4] add hot_add_cpu hook to QEMUMachine Igor Mammedov
2013-04-30 6:34 ` [Qemu-devel] [PATCH 2/4] QMP: add cpu-add command Igor Mammedov
2013-04-30 13:46 ` Eduardo Habkost
2013-04-30 13:53 ` Peter Krempa [this message]
2013-04-30 13:56 ` Igor Mammedov
2013-04-30 6:34 ` [Qemu-devel] [PATCH 3/4] add cpu-model option to -machine Igor Mammedov
2013-04-30 12:09 ` Eduardo Habkost
2013-04-30 6:34 ` [Qemu-devel] [PATCH 4/4] target-i386: implement machine->hot_add_cpu hook Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FCCF4.4020906@redhat.com \
--to=pkrempa@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).