From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56649)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pkrempa@redhat.com>) id 1UXAz0-0000rc-Ul
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 09:52:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pkrempa@redhat.com>) id 1UXAyy-00085D-9p
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 09:52:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37863)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pkrempa@redhat.com>) id 1UXAyy-00084U-2d
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 09:52:36 -0400
Message-ID: <517FCCF4.4020906@redhat.com>
Date: Tue, 30 Apr 2013 15:53:56 +0200
From: Peter Krempa <pkrempa@redhat.com>
MIME-Version: 1.0
References: <1367303643-16036-1-git-send-email-imammedo@redhat.com>
	<1367303643-16036-3-git-send-email-imammedo@redhat.com>
	<20130430134620.GB28606@otherpad.lan.raisama.net>
In-Reply-To: <20130430134620.GB28606@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [libvirt] [PATCH 2/4] QMP: add cpu-add command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, Igor Mammedov <imammedo@redhat.com>, afaerber@suse.de

On 04/30/13 15:46, Eduardo Habkost wrote:
> (CCing libvir-list)
>
> On Tue, Apr 30, 2013 at 08:34:01AM +0200, Igor Mammedov wrote:
>> Adds "cpu-add id=xxx" QMP command.
>>
>> cpu-add's "id" argument is a CPU number in a range [0..max-cpus)
>>
>> Example QMP command:
>>   -> { "execute": "cpu-add", "arguments": { "id": 2 } }
>>   <- { "return": {} }
>>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> The only way to find out if CPU hotplug is really available on a given
> machine-type is by actually trying to run cpu-add, right? Is this
> sufficient for libvirt requirements?
>
>


As long as the command fails when it's not supported it's okay.

(cpu_set HMP command does not fail when offlining a cpu even if it isn't 
supported and that's real pain to use)

Peter