From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>,
av1474@comtv.ru, qemu-devel@nongnu.org,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 7/8] audio: look for the ISA and PCI buses
Date: Tue, 30 Apr 2013 16:00:04 +0200 [thread overview]
Message-ID: <517FCE64.3080403@redhat.com> (raw)
In-Reply-To: <517FB63A.6070303@suse.de>
Il 30/04/2013 14:16, Andreas Färber ha scritto:
>
> The patch version committed has an additional change in this file:
>
> @@ -88,7 +88,6 @@ static void pc_init1(MemoryRegion *system_memory,
> void *fw_cfg = NULL;
>
> pc_cpus_init(cpu_model);
> - pc_acpi_init("acpi-dsdt.aml");
>
> if (kvmclock_enabled) {
> kvmclock_create();
>
> Was that accidental? Noticed because of a conflict with Igor's patches.
Yes, it must have been introduced when applying, because this wasn't a
pull request. I'll send a patch to revert.
> Further, my Reviewed-by is missing on patch 1/8, so was maybe the
> previous RFC version committed accidentally instead of this one?
No, the RFC only had 6 patches and patches 6-7-8 were completely
different (and broken).
Paolo
next prev parent reply other threads:[~2013-04-30 14:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 16:43 [Qemu-devel] [PATCH 1.5 0/8] make audio card configuration uniform Paolo Bonzini
2013-04-18 16:43 ` [Qemu-devel] [PATCH 1/8] adlib: qdev-ify Paolo Bonzini
2013-04-29 17:26 ` Andreas Färber
2013-04-18 16:43 ` [Qemu-devel] [PATCH 2/8] audio: remove the need for audio card CONFIG_* symbols Paolo Bonzini
2013-04-18 16:43 ` [Qemu-devel] [PATCH 3/8] audio: remove HAS_AUDIO Paolo Bonzini
2013-04-18 16:44 ` [Qemu-devel] [PATCH 4/8] audio: remove CONFIG_* symbols Paolo Bonzini
2013-04-18 16:44 ` [Qemu-devel] [PATCH 5/8] audio: replace audio card configuration with default-configs Paolo Bonzini
2013-04-18 16:44 ` [Qemu-devel] [PATCH 6/8] qom: do not return root for empty path Paolo Bonzini
2013-04-29 17:30 ` Andreas Färber
2013-04-18 16:44 ` [Qemu-devel] [PATCH 7/8] audio: look for the ISA and PCI buses Paolo Bonzini
2013-04-30 12:16 ` Andreas Färber
2013-04-30 14:00 ` Paolo Bonzini [this message]
2013-04-30 14:39 ` Anthony Liguori
2013-04-30 12:52 ` Alexander Graf
2013-04-18 16:44 ` [Qemu-devel] [PATCH 8/8] audio: enable PCI audio cards for all PCI-enabled targets Paolo Bonzini
2013-04-29 15:51 ` [Qemu-devel] [PATCH 1.5 0/8] make audio card configuration uniform Paolo Bonzini
2013-04-30 18:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FCE64.3080403@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=av1474@comtv.ru \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).