From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXDmx-0001Tm-Dy for qemu-devel@nongnu.org; Tue, 30 Apr 2013 12:52:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXDmu-0008AG-6X for qemu-devel@nongnu.org; Tue, 30 Apr 2013 12:52:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48105 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXCnO-0003cG-5m for qemu-devel@nongnu.org; Tue, 30 Apr 2013 11:48:46 -0400 Message-ID: <517FE7DC.8020802@suse.de> Date: Tue, 30 Apr 2013 17:48:44 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1367329288-27178-1-git-send-email-imammedo@redhat.com> <1367329288-27178-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1367329288-27178-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/5] add hot_add_cpu hook to QEMUMachine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Peter Maydell , aliguori@us.ibm.com, ehabkost@redhat.com, qemu-devel@nongnu.org, anthony.perard@citrix.com, pbonzini@redhat.com Am 30.04.2013 15:41, schrieb Igor Mammedov: > Hook should be set by target that implements > CPU hot-add via cpu-add QMP command. >=20 > Signed-off-by: Igor Mammedov > --- > include/hw/boards.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to qom-cpu (using a typedef and regrouping it): https://github.com/afaerber/qemu-cpu/commits/qom-cpu This is obviously tied to how the QMP command looks like, but I don't see much room to rearchitect that today - if machines can't support this simplified interface due to complex SoC setups they simply don't implement this hook and cpu-add should fail. Andreas > diff --git a/include/hw/boards.h b/include/hw/boards.h > index 425bdc7..75cd127 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -43,6 +43,7 @@ typedef struct QEMUMachine { > GlobalProperty *compat_props; > struct QEMUMachine *next; > const char *hw_version; > + void (*hot_add_cpu)(const int64_t id, Error **errp); > } QEMUMachine; > =20 > int qemu_register_machine(QEMUMachine *m); --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg