From: Laszlo Ersek <lersek@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: kraxel@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH v2 2/5] pc: remove needless includes
Date: Mon, 2 Oct 2023 16:41:56 +0200 [thread overview]
Message-ID: <517c17c6-b498-1641-ab3b-a7822ccec927@redhat.com> (raw)
In-Reply-To: <20231002111154.1002655-3-marcandre.lureau@redhat.com>
On 10/2/23 13:11, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The include list is gigantic, make it smaller.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/i386/pc.c | 41 -----------------------------------------
> 1 file changed, 41 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 5d399b6247..c376c5032d 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -24,79 +24,38 @@
>
> #include "qemu/osdep.h"
> #include "qemu/units.h"
> -#include "hw/i386/x86.h"
> #include "hw/i386/pc.h"
> #include "hw/char/serial.h"
> #include "hw/char/parallel.h"
> -#include "hw/i386/topology.h"
> #include "hw/i386/fw_cfg.h"
> #include "hw/i386/vmport.h"
> #include "sysemu/cpus.h"
> -#include "hw/block/fdc.h"
> #include "hw/ide/internal.h"
> -#include "hw/ide/isa.h"
> -#include "hw/pci/pci.h"
> -#include "hw/pci/pci_bus.h"
> -#include "hw/pci-bridge/pci_expander_bridge.h"
> -#include "hw/nvram/fw_cfg.h"
> #include "hw/timer/hpet.h"
> -#include "hw/firmware/smbios.h"
> #include "hw/loader.h"
> -#include "elf.h"
> -#include "migration/vmstate.h"
> -#include "multiboot.h"
> #include "hw/rtc/mc146818rtc.h"
> #include "hw/intc/i8259.h"
> -#include "hw/intc/ioapic.h"
> #include "hw/timer/i8254.h"
> #include "hw/input/i8042.h"
> -#include "hw/irq.h"
> #include "hw/audio/pcspk.h"
> -#include "hw/pci/msi.h"
> -#include "hw/sysbus.h"
> #include "sysemu/sysemu.h"
> -#include "sysemu/tcg.h"
> -#include "sysemu/numa.h"
> -#include "sysemu/kvm.h"
> #include "sysemu/xen.h"
> #include "sysemu/reset.h"
> -#include "sysemu/runstate.h"
> #include "kvm/kvm_i386.h"
> -#include "hw/xen/xen.h"
> -#include "hw/xen/start_info.h"
> -#include "ui/qemu-spice.h"
> -#include "exec/memory.h"
> -#include "qemu/bitmap.h"
> -#include "qemu/config-file.h"
> -#include "qemu/error-report.h"
> -#include "qemu/option.h"
> -#include "qemu/cutils.h"
> -#include "hw/acpi/acpi.h"
> #include "hw/acpi/cpu_hotplug.h"
> #include "acpi-build.h"
> -#include "hw/mem/pc-dimm.h"
> #include "hw/mem/nvdimm.h"
> -#include "hw/cxl/cxl.h"
> #include "hw/cxl/cxl_host.h"
> -#include "qapi/error.h"
> -#include "qapi/qapi-visit-common.h"
> -#include "qapi/qapi-visit-machine.h"
> -#include "qapi/visitor.h"
> -#include "hw/core/cpu.h"
> #include "hw/usb.h"
> #include "hw/i386/intel_iommu.h"
> #include "hw/net/ne2000-isa.h"
> -#include "standard-headers/asm-x86/bootparam.h"
> #include "hw/virtio/virtio-iommu.h"
> #include "hw/virtio/virtio-md-pci.h"
> #include "hw/i386/kvm/xen_overlay.h"
> #include "hw/i386/kvm/xen_evtchn.h"
> #include "hw/i386/kvm/xen_gnttab.h"
> #include "hw/i386/kvm/xen_xenstore.h"
> -#include "sysemu/replay.h"
> -#include "target/i386/cpu.h"
> #include "e820_memory_layout.h"
> -#include "fw_cfg.h"
> #include "trace.h"
> #include CONFIG_DEVICES
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2023-10-02 14:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 11:11 [PATCH v2 0/5] ramfb: migration support marcandre.lureau
2023-10-02 11:11 ` [PATCH v2 1/5] hw: remove needless includes marcandre.lureau
2023-10-02 14:41 ` Laszlo Ersek
2023-10-02 11:11 ` [PATCH v2 2/5] pc: " marcandre.lureau
2023-10-02 14:41 ` Laszlo Ersek [this message]
2023-10-02 11:11 ` [PATCH v2 3/5] ramfb: implement migration support marcandre.lureau
2023-10-02 12:01 ` Marc-André Lureau
2023-10-02 14:20 ` Laszlo Ersek
2023-10-02 14:34 ` Laszlo Ersek
2023-10-02 11:11 ` [PATCH v2 4/5] ramfb: make migration conditional marcandre.lureau
2023-10-02 13:38 ` Cédric Le Goater
2023-10-02 14:41 ` Alex Williamson
2023-10-02 18:24 ` Laszlo Ersek
2023-10-02 19:26 ` Alex Williamson
2023-10-02 19:41 ` Laszlo Ersek
2023-10-02 20:38 ` Alex Williamson
2023-10-02 20:46 ` Laszlo Ersek
2023-10-03 7:41 ` Cédric Le Goater
2023-10-03 8:23 ` Marc-André Lureau
2023-10-03 8:28 ` Cédric Le Goater
2023-10-02 14:40 ` Laszlo Ersek
2023-10-02 11:11 ` [PATCH v2 5/5] hw: turn off ramfb migration for machines <= 8.1 marcandre.lureau
2023-10-02 14:41 ` Laszlo Ersek
2023-10-03 9:07 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517c17c6-b498-1641-ab3b-a7822ccec927@redhat.com \
--to=lersek@redhat.com \
--cc=eduardo@habkost.net \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).