From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXEiJ-0007qX-4R for qemu-devel@nongnu.org; Tue, 30 Apr 2013 13:51:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXEiE-0005fZ-31 for qemu-devel@nongnu.org; Tue, 30 Apr 2013 13:51:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXEiD-0005fE-R7 for qemu-devel@nongnu.org; Tue, 30 Apr 2013 13:51:34 -0400 Message-ID: <51800483.3090203@redhat.com> Date: Tue, 30 Apr 2013 11:50:59 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366968675-1451-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1366968675-1451-7-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1366968675-1451-7-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2VJUCCBKDACUXWBUQVOSS" Subject: Re: [Qemu-devel] [PATCH 6/7] block: move qmp and info dump related code to block/qapi.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@gmail.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VJUCCBKDACUXWBUQVOSS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/26/2013 03:31 AM, Wenchao Xia wrote: > This patch is a pure code move patch, except following modification: > 1 get_human_readable_size() is changed to static function. > 2 dump_human_image_info() is renamed to bdrv_image_info_dump(). > 3 in qmp_query_block() and qmp_query_blockstats, use bdrv_next(bs) > instead of direct traverse of global array 'bdrv_states'. > 4 code style fix. >=20 > Now block.h and snapshot.h are at the same level in include path, > block_int.h and qapi.h will both include them. >=20 > Signed-off-by: Wenchao Xia > --- > block.c | 185 --------------------------------- > block/qapi.c | 253 +++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/block.h | 10 -- > include/block/block_int.h | 1 + > include/block/qapi.h | 6 + > qemu-img.c | 69 +------------ > savevm.c | 1 + > 7 files changed, 262 insertions(+), 263 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2VJUCCBKDACUXWBUQVOSS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRgASDAAoJEKeha0olJ0NqURYH/3bcpg6jqf/r+zxSgwjiMQ2+ JdQJD03cyq5tPyW7pCfCgZqR88qSM2Uq71YzqaMpkx/bHDeB4AO4y3jDUikW8raq HqXlh8Ff+ZiypVIBlxyHmB3dBrQxTFpoV3yY8zIvRnd71ymavzNe6tJnqdug44X5 Ehj8zY7CvwF0d1M/dBBT+SHIm8d0Wd8LgwXa0MJvcgjxnpV4vOakjhNfRZ7FuG8H AdPuVw7Hr22nCBSrv3Wy8EpEonZCLhFV7woa5/NYLi+VqFEZGez4k1H2Vc2rp7aC X9qBSH38l0AyQuKNwBQxNypYklFgAz/9Sqhrr9PDYgNhZZmQo2pLmJQ1Cit/8ew= =mTH7 -----END PGP SIGNATURE----- ------enig2VJUCCBKDACUXWBUQVOSS--