From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXWIq-0004fx-Jy for qemu-devel@nongnu.org; Wed, 01 May 2013 08:38:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXWIm-0003tP-I5 for qemu-devel@nongnu.org; Wed, 01 May 2013 08:38:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXWIm-0003tL-9K for qemu-devel@nongnu.org; Wed, 01 May 2013 08:38:28 -0400 Message-ID: <51810CC0.2080407@redhat.com> Date: Wed, 01 May 2013 06:38:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1367410972-22972-1-git-send-email-chegu_vinod@hp.com> In-Reply-To: <1367410972-22972-1-git-send-email-chegu_vinod@hp.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2QCEBXLNVQVRSLQJHSEFS" Subject: Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chegu Vinod Cc: owasserm@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2QCEBXLNVQVRSLQJHSEFS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/01/2013 06:22 AM, Chegu Vinod wrote: > Busy enterprise workloads hosted on large sized VM's tend to dirty > memory faster than the transfer rate achieved via live guest migration.= > Despite some good recent improvements (& using dedicated 10Gig NICs > between hosts) the live migration does NOT converge. >=20 > --- >=20 > Changes from v2: > - incorporated feedback from Orit, Juan and Eric > - stop the throttling thread at the start of stage 3 > - rebased to latest qemu.git >=20 > +++ b/qapi-schema.json > @@ -600,9 +600,14 @@ > # loads, by sending compressed difference of the pages > # > # Since: 1.2 > +# > +# @auto-converge: Migration supports automatic throttling down of gues= t > +# to force convergence. Disabled by default. > +# > +# Since: 1.6 > ## I've already argued that ALL new migration capabilities should be disabled by default (see the thread on 'x-rdma-pin-all', which will be a merge conflict if it gets applied before your patch). So I don't think that last sentence adds anything, and can be dropped. I think this works, although it's the first instance of having two top-level Since: tags on a single JSON entity. I was envisioning: @xbzrle: yadda... pages @auto-convert: Migration supports... convergence (since 1.6) Since: 1.2 to match the conventions elsewhere that the overall JSON entity (the enum MigrationCapability) exists since 1.2, but the addition of auto-convert happened in 1.6. However, as nothing parses the .json file to turn it into formal docs (yet), I'm not going to insist on a respin if this is the only problem with your patch. I'm not comfortable enough with my skills in reviewing the rest of the patch, or I'd offer a reviewed-by. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2QCEBXLNVQVRSLQJHSEFS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRgQzAAAoJEKeha0olJ0NqMo8IAI0EPVrnVFcVJsES1JdZofI2 M9SRmwQhT5VRAL7SjzL6jK+k4DEkzFrJiD+mcQpl63AGfWGCroAZskSXNnZXLmij CvriHXp4gtRt2ZEZjqD3xQfnPwjG/OJUUI1TezilM+zSEB+vKQFcAo7L7+9K0k9O 6zgH19loh5SnHf2XxDHVsEozRNAY0zFNg8IMYrqt4UgLFdbIvsMkxFK7EZLkoV3l Ld38vC0ed7d0Z2rllhvz434ajS0Ybc1Hv1+zM6Ine+0zAqAsn0hCW4t1bSlindll xqMeFtlCEcLdqxuz6QQOKnqWj55yNiIPac2PpL9kH/Gmsc+IyZ1sNMZ6/zwu4VM= =WEQN -----END PGP SIGNATURE----- ------enig2QCEBXLNVQVRSLQJHSEFS--