From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXWUe-0000hg-8n for qemu-devel@nongnu.org; Wed, 01 May 2013 08:50:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXWUa-00080G-6R for qemu-devel@nongnu.org; Wed, 01 May 2013 08:50:44 -0400 Received: from g4t0014.houston.hp.com ([15.201.24.17]:2873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXWUZ-00080C-W9 for qemu-devel@nongnu.org; Wed, 01 May 2013 08:50:40 -0400 Message-ID: <51810F9D.3000605@hp.com> Date: Wed, 01 May 2013 05:50:37 -0700 From: Chegu Vinod MIME-Version: 1.0 References: <1367410972-22972-1-git-send-email-chegu_vinod@hp.com> <51810CC0.2080407@redhat.com> In-Reply-To: <51810CC0.2080407@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: owasserm@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, quintela@redhat.com On 5/1/2013 5:38 AM, Eric Blake wrote: > On 05/01/2013 06:22 AM, Chegu Vinod wrote: >> Busy enterprise workloads hosted on large sized VM's tend to dirty >> memory faster than the transfer rate achieved via live guest migration. >> Despite some good recent improvements (& using dedicated 10Gig NICs >> between hosts) the live migration does NOT converge. >> --- >> >> Changes from v2: >> - incorporated feedback from Orit, Juan and Eric >> - stop the throttling thread at the start of stage 3 >> - rebased to latest qemu.git >> >> +++ b/qapi-schema.json >> @@ -600,9 +600,14 @@ >> # loads, by sending compressed difference of the pages >> # >> # Since: 1.2 >> +# >> +# @auto-converge: Migration supports automatic throttling down of guest >> +# to force convergence. Disabled by default. >> +# >> +# Since: 1.6 >> ## > I've already argued that ALL new migration capabilities should be > disabled by default (see the thread on 'x-rdma-pin-all', which will be a > merge conflict if it gets applied before your patch). So I don't think > that last sentence adds anything, and can be dropped. > > I think this works, although it's the first instance of having two > top-level Since: tags on a single JSON entity. I was envisioning: > > @xbzrle: yadda... pages > > @auto-convert: Migration supports... convergence (since 1.6) > > Since: 1.2 > > to match the conventions elsewhere that the overall JSON entity (the > enum MigrationCapability) exists since 1.2, but the addition of > auto-convert happened in 1.6. > > However, as nothing parses the .json file to turn it into formal docs > (yet), I'm not going to insist on a respin if this is the only problem > with your patch. I'm not comfortable enough with my skills in reviewing > the rest of the patch, or I'd offer a reviewed-by. > I shall make the suggested changes. Appreciate your review feedback on this part of the change. Thanks Vinod