qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com,
	Peter Crosthwaite <crosthwaitepeter@gmail.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL v1 17/21] sparc: Remove ELF_MACHINE from cpu.h
Date: Thu, 10 Sep 2015 22:44:39 -0700	[thread overview]
Message-ID: <5181a5e88c3a58b69dece733ef558593b6a3698f.1441695816.git.crosthwaite.peter@gmail.com> (raw)
In-Reply-To: <cover.1441695816.git.crosthwaite.peter@gmail.com>
In-Reply-To: <cover.1441695816.git.crosthwaite.peter@gmail.com>

From: Peter Crosthwaite <crosthwaitepeter@gmail.com>

The bootloaders can just pass EM_SPARC or EM_SPARCV9 directly, as
they are architecture specific code (to one or the other).

This removes another architecture specific definition from the global
namespace.

Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Acked-By: Riku Voipio <riku.voipio@linaro.org>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---

 hw/sparc/leon3.c   | 2 +-
 hw/sparc/sun4m.c   | 4 ++--
 hw/sparc64/sun4u.c | 4 ++--
 target-sparc/cpu.h | 6 ------
 4 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index 7f5dcd6..2d7ec76 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -193,7 +193,7 @@ static void leon3_generic_hw_init(MachineState *machine)
         uint64_t entry;
 
         kernel_size = load_elf(kernel_filename, NULL, NULL, &entry, NULL, NULL,
-                               1 /* big endian */, ELF_MACHINE, 0);
+                               1 /* big endian */, EM_SPARC, 0);
         if (kernel_size < 0) {
             fprintf(stderr, "qemu: could not load kernel '%s'\n",
                     kernel_filename);
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 68ac4d8..6eb7ef8 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -300,7 +300,7 @@ static unsigned long sun4m_load_kernel(const char *kernel_filename,
         bswap_needed = 0;
 #endif
         kernel_size = load_elf(kernel_filename, translate_kernel_address, NULL,
-                               NULL, NULL, NULL, 1, ELF_MACHINE, 0);
+                               NULL, NULL, NULL, 1, EM_SPARC, 0);
         if (kernel_size < 0)
             kernel_size = load_aout(kernel_filename, KERNEL_LOAD_ADDR,
                                     RAM_size - KERNEL_LOAD_ADDR, bswap_needed,
@@ -744,7 +744,7 @@ static void prom_init(hwaddr addr, const char *bios_name)
     filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
     if (filename) {
         ret = load_elf(filename, translate_prom_address, &addr, NULL,
-                       NULL, NULL, 1, ELF_MACHINE, 0);
+                       NULL, NULL, 1, EM_SPARC, 0);
         if (ret < 0 || ret > PROM_SIZE_MAX) {
             ret = load_image_targphys(filename, addr, PROM_SIZE_MAX);
         }
diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index 30cfa0e..d359cb8 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -208,7 +208,7 @@ static uint64_t sun4u_load_kernel(const char *kernel_filename,
         bswap_needed = 0;
 #endif
         kernel_size = load_elf(kernel_filename, NULL, NULL, kernel_entry,
-                               kernel_addr, &kernel_top, 1, ELF_MACHINE, 0);
+                               kernel_addr, &kernel_top, 1, EM_SPARCV9, 0);
         if (kernel_size < 0) {
             *kernel_addr = KERNEL_LOAD_ADDR;
             *kernel_entry = KERNEL_LOAD_ADDR;
@@ -671,7 +671,7 @@ static void prom_init(hwaddr addr, const char *bios_name)
     filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
     if (filename) {
         ret = load_elf(filename, translate_prom_address, &addr,
-                       NULL, NULL, NULL, 1, ELF_MACHINE, 0);
+                       NULL, NULL, NULL, 1, EM_SPARCV9, 0);
         if (ret < 0 || ret > PROM_SIZE_MAX) {
             ret = load_image_targphys(filename, addr, PROM_SIZE_MAX);
         }
diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h
index 0522b65..b5ff644 100644
--- a/target-sparc/cpu.h
+++ b/target-sparc/cpu.h
@@ -31,12 +31,6 @@
 
 #include "fpu/softfloat.h"
 
-#if !defined(TARGET_SPARC64)
-#define ELF_MACHINE     EM_SPARC
-#else
-#define ELF_MACHINE     EM_SPARCV9
-#endif
-
 /*#define EXCP_INTERRUPT 0x100*/
 
 /* trap definitions */
-- 
1.9.1

  parent reply	other threads:[~2015-09-11  5:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11  5:44 [Qemu-devel] [PULL v1 00/21] Multi-arch queue Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 01/21] linux_user: elfload: Default ELF_MACHINE to ELF_ARCH Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 02/21] linux-user: elfload: Provide default for elf_check_arch Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 03/21] elf_ops: Fix coding style for EM alias case statement Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 04/21] elf: Update EM_MOXIE definition Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 05/21] arm: Remove ELF_MACHINE from cpu.h Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 06/21] mb: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 07/21] m68k: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 08/21] cris: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 09/21] moxie: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 10/21] unicore: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 12/21] or32: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 13/21] tricore: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 14/21] xtensa: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 15/21] sh4: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 16/21] s390: " Peter Crosthwaite
2015-09-11  5:44 ` Peter Crosthwaite [this message]
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 18/21] mips: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 19/21] alpha: " Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 20/21] i386: Rename ELF_MACHINE to be x86 specific Peter Crosthwaite
2015-09-11  5:44 ` [Qemu-devel] [PULL v1 21/21] ppc: Rename ELF_MACHINE to be PPC specific Peter Crosthwaite
2015-09-11  9:31 ` [Qemu-devel] [PULL v1 00/21] Multi-arch queue Peter Maydell
2015-09-11 14:45   ` Peter Crosthwaite
2015-09-22 13:58     ` Paolo Bonzini
2015-09-22 14:12       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5181a5e88c3a58b69dece733ef558593b6a3698f.1441695816.git.crosthwaite.peter@gmail.com \
    --to=crosthwaitepeter@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).