From: Richard Henderson <rth@twiddle.net>
To: Paul Guo <ggang@tilera.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu/virtio issue due to non-atomic data access
Date: Thu, 02 May 2013 11:06:15 +0100 [thread overview]
Message-ID: <51823A97.5090505@twiddle.net> (raw)
In-Reply-To: <51822DFF.4070300@tilera.com>
On 2013-05-02 10:12, Paul Guo wrote:
> A proper fix for this issue seems to be: Judge whether the address is aligned, do direct loading for the aligned case in ldq_le_p(), etc?
No, I would think the proper fix would be to change the bits of virtio that are
known to access aligned memory to not use the pointer wrapper functions, but to
use a normal C memory access followed by leN_to_cpu et al.
r~
next prev parent reply other threads:[~2013-05-02 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 9:12 [Qemu-devel] qemu/virtio issue due to non-atomic data access Paul Guo
2013-05-02 10:06 ` Richard Henderson [this message]
2013-05-03 3:20 ` Paul Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51823A97.5090505@twiddle.net \
--to=rth@twiddle.net \
--cc=ggang@tilera.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).