From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXrYt-0004oY-JY for qemu-devel@nongnu.org; Thu, 02 May 2013 07:20:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXrYs-0005Eu-9d for qemu-devel@nongnu.org; Thu, 02 May 2013 07:20:31 -0400 Received: from goliath.siemens.de ([192.35.17.28]:31727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXrYr-0005Dp-Px for qemu-devel@nongnu.org; Thu, 02 May 2013 07:20:30 -0400 Message-ID: <51824BF9.4030205@siemens.com> Date: Thu, 02 May 2013 13:20:25 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <50327DD8.8070205@siemens.com> <50333245.3060501@redhat.com> In-Reply-To: <50333245.3060501@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel On 2012-08-21 09:01, Paolo Bonzini wrote: > Il 20/08/2012 20:11, Jan Kiszka ha scritto: >> VCPUs are either resumed directly via vm_start, after the incoming >> migration is done, or when a continue command is issued. We don't need >> the explicit resume before entering main_loop. >> >> Signed-off-by: Jan Kiszka >> --- >> >> I was adding nesting support to pause/resume_all_vcpus, and that >> stumbled over the imbalance below. >> >> vl.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index ebee867..231d3ab 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -3757,7 +3757,6 @@ int main(int argc, char **argv, char **envp) >> >> os_setup_post(); >> >> - resume_all_vcpus(); >> main_loop(); >> bdrv_close_all(); >> pause_all_vcpus(); >> > > Makes sense. Do we need a "main loop and similar" tree, or can that > tree be just uq/master now that qemu-kvm.c is dying? > > Paolo > Just noticed that this cleanup didn't make it into upstream back then. Not truly trivial, but also not really risky. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux