Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator.

["Andreas Färber" <afaerber@suse.de>]

Hi,

Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS:
> Signed-off-by: Jean-Christophe DUBOIS <jcd@tribudubois.net>
> ---
>  default-configs/arm-softmmu.mak |   2 +
>  hw/i2c/Makefile.objs            |   1 +
>  hw/i2c/imx_i2c.c                | 374 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 377 insertions(+)
>  create mode 100644 hw/i2c/imx_i2c.c

Please thread your messages together so they can be reviewed in context.

Since you're adding a new I2C device and we have a qtest framework for
I2C, please supply an implementation for this device (which will require
some constant sharing via header file) and some simple test case for the
board you're using it on, to assure it keeps working.

In addition to Peter C.'s comments:

[...]
> diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c
> new file mode 100644
> index 0000000..30d3f5c
> --- /dev/null
> +++ b/hw/i2c/imx_i2c.c
[...]
> +type_init(imx_i2c_register_types);

This declares a function and is not a statement, so no semicolon please.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg