From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXsm7-0003yX-JS for qemu-devel@nongnu.org; Thu, 02 May 2013 08:38:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXsm2-0003aW-Vi for qemu-devel@nongnu.org; Thu, 02 May 2013 08:38:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43938 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXsm2-0003aL-PF for qemu-devel@nongnu.org; Thu, 02 May 2013 08:38:10 -0400 Message-ID: <51825E30.5000802@suse.de> Date: Thu, 02 May 2013 14:38:08 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1367438026-27573-1-git-send-email-jcd@tribudubois.net> In-Reply-To: <1367438026-27573-1-git-send-email-jcd@tribudubois.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] Add i.MX I2C device emulator. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jean-Christophe DUBOIS Cc: peter.maydell@linaro.org, Peter Crosthwaite , peter.chubb@nicta.com.au, qemu-devel@nongnu.org Hi, Am 01.05.2013 21:53, schrieb Jean-Christophe DUBOIS: > Signed-off-by: Jean-Christophe DUBOIS > --- > default-configs/arm-softmmu.mak | 2 + > hw/i2c/Makefile.objs | 1 + > hw/i2c/imx_i2c.c | 374 ++++++++++++++++++++++++++++++++= ++++++++ > 3 files changed, 377 insertions(+) > create mode 100644 hw/i2c/imx_i2c.c Please thread your messages together so they can be reviewed in context. Since you're adding a new I2C device and we have a qtest framework for I2C, please supply an implementation for this device (which will require some constant sharing via header file) and some simple test case for the board you're using it on, to assure it keeps working. In addition to Peter C.'s comments: [...] > diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c > new file mode 100644 > index 0000000..30d3f5c > --- /dev/null > +++ b/hw/i2c/imx_i2c.c [...] > +type_init(imx_i2c_register_types); This declares a function and is not a statement, so no semicolon please. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg