From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXuFk-00038v-Mr for qemu-devel@nongnu.org; Thu, 02 May 2013 10:13:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXu8m-0006hj-Ap for qemu-devel@nongnu.org; Thu, 02 May 2013 10:06:01 -0400 Received: from greensocs.com ([87.106.252.221]:38365 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXu8l-0006hH-Tp for qemu-devel@nongnu.org; Thu, 02 May 2013 10:05:44 -0400 Message-ID: <518272AD.8020809@greensocs.com> Date: Thu, 02 May 2013 16:05:33 +0200 From: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= MIME-Version: 1.0 References: <1367330931-12994-1-git-send-email-fred.konrad@greensocs.com> <20130502154007.03cc7989@gondolin> In-Reply-To: <20130502154007.03cc7989@gondolin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus command line compatibility. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, Michal Privoznik , Libaiqing , mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, amit.shah@redhat.com, pbonzini@redhat.com, afaerber@suse.de On 02/05/2013 15:40, Cornelia Huck wrote: > On Tue, 30 Apr 2013 16:08:46 +0200 > fred.konrad@greensocs.com wrote: > >> From: KONRAD Frederic >> >> Cc: Libaiqing >> Cc: Michal Privoznik >> >> This fixes the bus name for virtio-serial-device and virtio-scsi-device. >> >> The bus name for virtio-serial-device and virtio-scsi-device is not "id.0" as it >> was the case before the refactoring. >> >> This trigger the error: >> >> qemu-system-xxx -device virtio-serial-pci,id=virtio-serial0 >> -device virtserialport,bus=virtio-serial0.0 >> >> Bus 'virtio-serial0.0' is full >> Bus 'virtio-serial0.0' not found > Seems to look sane on s390-virtio and virtio-ccw. > > Tested-by: Cornelia Huck Thanks for that :). Fred > >> So this sets the name of those bus before the virtio-device's init. >> >> KONRAD Frederic (5): >> virtio-x-bus: force bus name to virtio-bus. >> virtio: add virtio_device_set_child_bus_name. >> scsi: add bus_name parameter to scsi_bus_new. >> virtio-serial: fix command line compatibility. >> virtio-scsi: fix the command line compatibility. >> >> hw/char/virtio-serial-bus.c | 3 ++- >> hw/s390x/s390-virtio-bus.c | 28 +++++++++++++++++++++++++++- >> hw/s390x/virtio-ccw.c | 28 +++++++++++++++++++++++++++- >> hw/scsi/esp-pci.c | 2 +- >> hw/scsi/esp.c | 2 +- >> hw/scsi/lsi53c895a.c | 2 +- >> hw/scsi/megasas.c | 2 +- >> hw/scsi/scsi-bus.c | 5 +++-- >> hw/scsi/spapr_vscsi.c | 2 +- >> hw/scsi/virtio-scsi.c | 3 ++- >> hw/scsi/vmw_pvscsi.c | 2 +- >> hw/usb/dev-storage.c | 4 ++-- >> hw/usb/dev-uas.c | 2 +- >> hw/virtio/virtio-pci.c | 29 ++++++++++++++++++++++++++++- >> hw/virtio/virtio.c | 24 ++++++++++++++++++++++++ >> include/hw/scsi/scsi.h | 3 ++- >> include/hw/virtio/virtio-scsi.h | 1 - >> include/hw/virtio/virtio.h | 4 ++++ >> 18 files changed, 128 insertions(+), 18 deletions(-) >>