From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UXx0I-0007B5-BE
	for qemu-devel@nongnu.org; Thu, 02 May 2013 13:09:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UXx0D-0002JL-Fh
	for qemu-devel@nongnu.org; Thu, 02 May 2013 13:09:10 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55413 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UXx0D-0002GT-9V
	for qemu-devel@nongnu.org; Thu, 02 May 2013 13:09:05 -0400
Message-ID: <51829DAC.5020807@suse.de>
Date: Thu, 02 May 2013 19:09:00 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20130502135143.GA1171@redhat.com>
	<CAFEAcA_Jm8sgQnNMrrz5H1B1KAgrtiaDm3Br_qbfyFO_D-a+rA@mail.gmail.com>
	<20130502141704.GA12954@redhat.com>
	<CAFEAcA88=RPu-1w5ZxLOE5nKF_xLAB4mX7x1fa6w_VpmoBJ3Sw@mail.gmail.com>
	<51827C37.403@redhat.com>
	<CAFEAcA8fsj-pEmNG44VYjV5WYL=g8Hg_ptzXCRNczrM_tfQFqg@mail.gmail.com>
	<51828D58.5020103@suse.de>
	<CAFEAcA_bQbtV=OmX=UytJVGURo0zYqeBsPP6fs=LNuABZZqXDA@mail.gmail.com>
In-Reply-To: <CAFEAcA_bQbtV=OmX=UytJVGURo0zYqeBsPP6fs=LNuABZZqXDA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH
 08/29] cpu: Add qemu_for_each_cpu())
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

Am 02.05.2013 18:08, schrieb Peter Maydell:
> On 2 May 2013 16:59, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Am 02.05.2013 16:57, schrieb Peter Maydell:
>>> Wow, you trust get_maintainer.pl that much? IME it
>>> tends to give a huge pile of useless cc suggestions.
>>
>> Useless? It's based on MAINTAINERS, which I expect maintainers to keep
>> up-to-date if they no longer want to maintain something. It's rather
>> that new files don't get entries and thus too few CCs at times IME.
>=20
> The ccs based on MAINTAINERS are fine -- it's the random
> extras it picks based on other people who've made patches
> to the same files in the past that are usually wrong.
> For example I tried running it on a patch to MAINTAINERS
> itself, and it suggested ccing you, Alex, Stefan H,
> Peter Crosthwaite and Edgar, which is a random mishmash
> and doesn't include the key person you actually need
> to CC, ie Anthony.

That's why Gerd correctly wrote scripts/get_maintainer.pl
--nogit-fallback - it doesn't do what you claim, although the default doe=
s.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg