From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UXxDS-0004Sf-H2
	for qemu-devel@nongnu.org; Thu, 02 May 2013 13:22:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UXxDQ-0006en-Hb
	for qemu-devel@nongnu.org; Thu, 02 May 2013 13:22:46 -0400
Received: from mail-gh0-f177.google.com ([209.85.160.177]:51987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UXxDQ-0006ed-D1
	for qemu-devel@nongnu.org; Thu, 02 May 2013 13:22:44 -0400
Received: by mail-gh0-f177.google.com with SMTP id f20so121433ghb.8
	for <qemu-devel@nongnu.org>; Thu, 02 May 2013 10:22:44 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5182A0DE.5030709@redhat.com>
Date: Thu, 02 May 2013 19:22:38 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367497388-5962-1-git-send-email-stefanha@redhat.com>
In-Reply-To: <1367497388-5962-1-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] nbd: support large NBD requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Nick Thomas <nick@bytemark.co.uk>

Il 02/05/2013 14:23, Stefan Hajnoczi ha scritto:
> These patches switch from fixed-size 1 MB data buffers to dynamically sized
> buffers in NBD.  This is necessary because the Linux nbd driver now allows up
> to 32 MB request size.
> 
> Patch 1 gets rid of the request freelist, which becomes pointless when data
> buffers are no longer reused.
> 
> Patch 2 dynamically sizes the data buffer.
> 
> Stefan Hajnoczi (2):
>   nbd: use g_slice_new() instead of a freelist
>   nbd: support large NBD requests
> 
>  include/block/nbd.h |  3 ++-
>  nbd.c               | 36 +++++++++++++++---------------------
>  2 files changed, 17 insertions(+), 22 deletions(-)
> 

The limit is now 0.5 GB per NBD device.  It's quite a lot, but still
bearable and should be lower usually.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo