From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UY66I-0006fi-3D for qemu-devel@nongnu.org; Thu, 02 May 2013 22:51:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UY66H-0004Ti-6D for qemu-devel@nongnu.org; Thu, 02 May 2013 22:51:58 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:39138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UY66G-0004Sj-LR for qemu-devel@nongnu.org; Thu, 02 May 2013 22:51:57 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 May 2013 08:18:01 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 46E72E002D for ; Fri, 3 May 2013 08:23:57 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r432pcw612190030 for ; Fri, 3 May 2013 08:21:39 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r432phbq010914 for ; Fri, 3 May 2013 12:51:43 +1000 Message-ID: <51832636.1020900@linux.vnet.ibm.com> Date: Fri, 03 May 2013 10:51:34 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1366968675-1451-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1366968675-1451-8-git-send-email-xiawenc@linux.vnet.ibm.com> <20130426144657.GB7648@stefanha-thinkpad.redhat.com> <20130429150541.298db151@redhat.com> <5181C9D4.4000905@linux.vnet.ibm.com> <20130502080206.21df203f@redhat.com> In-Reply-To: <20130502080206.21df203f@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, phrdina@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com 于 2013-5-2 20:02, Luiz Capitulino 写道: > On Thu, 02 May 2013 10:05:08 +0800 > Wenchao Xia wrote: > >> 于 2013-4-30 3:05, Luiz Capitulino 写道: >>> On Fri, 26 Apr 2013 16:46:57 +0200 >>> Stefan Hajnoczi wrote: >>> >>>> On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote: >>>>> @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon, const QDict *qdict) >>>>> } >>>>> >>>>> if (total > 0) { >>>>> - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf), NULL)); >>>>> + bdrv_snapshot_dump(NULL); >>>>> + monitor_printf(mon, "\n"); >>>> >>>> Luiz: any issue with mixing monitor_printf(mon) and >>>> monitor_vprintf(cur_mon) calls? I guess there was a reason for >>>> explicitly passing mon instead of relying on cur_mon. >>> >>> where are they being mixed? >>> >> bdrv_snapshot_dump() used a global variable "cur_mon" inside, instead >> of let caller pass in a explicit montior* "mon", I guess that is the >> question. > > I'd have to see the code to tell, but yes, what Stefan described is the > best practice for the Monitor. > I think this would not be a problem until qemu wants more than one human monitor console, and then we may require a data structure to tell where to output the string: stdout, *mon, or even stderr, and error_printf() also need to be changed. -- Best Regards Wenchao Xia