From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UY8tG-0004ai-9p for qemu-devel@nongnu.org; Fri, 03 May 2013 01:50:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UY8tF-00006i-2d for qemu-devel@nongnu.org; Fri, 03 May 2013 01:50:42 -0400 Message-ID: <5183502A.3070800@reactos.org> Date: Fri, 03 May 2013 07:50:34 +0200 From: =?ISO-8859-1?Q?Herv=E9_Poussineau?= MIME-Version: 1.0 References: <1367525344-7755-1-git-send-email-hpoussin@reactos.org> <1367525344-7755-5-git-send-email-hpoussin@reactos.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each nvram type we support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko Cc: Blue Swirl , qemu-ppc@nongnu.org, qemu-devel , =?ISO-8859-1?Q?Andreas_F=E4rber?= Artyom Tarasenko a =E9crit : > On Thu, May 2, 2013 at 10:09 PM, Herv=E9 Poussineau wrote: >> As m48t59 devices can only be created with m48t59_init() or m48t59_ini= t_isa(), >> we know exactly which nvram types are required. Register only those th= ree >> types. >=20 > Wasn't this patch NACKed by Blue? I think I changed what's requested, ie I kept the io-base property of=20 the ISA variant, so the sun4u emulation can be changed later to the=20 right address. However, fixing sun4u emulation is not part of this patchs= et. Otherwise, if I didn't understood, please elaborate. Regards, Herv=E9