From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Jordan Justen <jordan.l.justen@intel.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/6] kvm: workaround a possible KVM bug when using KVM_MEM_READONLY
Date: Fri, 03 May 2013 14:13:17 +0800 [thread overview]
Message-ID: <5183557D.9080202@linux.vnet.ibm.com> (raw)
In-Reply-To: <1367137941-4310-4-git-send-email-jordan.l.justen@intel.com>
On 04/28/2013 04:32 PM, Jordan Justen wrote:
> On a Linux 3.8.0 based kernel, I occasionally saw a situation
> where the memory region would continue to trap on memory
> read even though KVM_MEM_READONLY was set.
>
> I found that if I set the slot to a size of 0, and before
> setting the slot, it would then behave as expected.
Yes, the KVM_MEM_READONLY flag can not be directly changed, see
the commit 75d61fbcf563373696578570e914f555e12c8d97 on kvm tree.
Do you think the way which deletes the memslot before changing
the KVM_MEM_READONLY hurts the performance? If yes, i will
make it be directly changed.
Thanks for you implementing the READONLY memory in Qemu.
Reviewed-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
next prev parent reply other threads:[~2013-05-03 6:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 8:32 [Qemu-devel] [PATCH 0/6] KVM flash memory support Jordan Justen
2013-04-28 8:32 ` [Qemu-devel] [PATCH 1/6] kvm: add kvm_readonly_mem_enabled Jordan Justen
2013-04-29 10:27 ` Jan Kiszka
2013-04-28 8:32 ` [Qemu-devel] [PATCH 2/6] kvm: support using KVM_MEM_READONLY flag for readonly regions Jordan Justen
2013-05-03 6:02 ` Xiao Guangrong
2013-04-28 8:32 ` [Qemu-devel] [PATCH 3/6] kvm: workaround a possible KVM bug when using KVM_MEM_READONLY Jordan Justen
2013-04-29 10:29 ` Jan Kiszka
2013-04-29 18:37 ` Jordan Justen
2013-05-03 6:13 ` Xiao Guangrong [this message]
2013-04-28 8:32 ` [Qemu-devel] [PATCH 4/6] pflash_cfi01: memory region should be set to enable readonly mode Jordan Justen
2013-04-28 8:32 ` [Qemu-devel] [PATCH 5/6] pc_sysfw: allow flash memory to be used with KVM Jordan Justen
2013-04-28 8:32 ` [Qemu-devel] [PATCH 6/6] pc_sysfw: change rom_only default to 0 Jordan Justen
2013-04-29 8:20 ` Paolo Bonzini
2013-04-29 18:23 ` Jordan Justen
2013-04-29 21:10 ` Paolo Bonzini
2013-04-30 3:51 ` Jordan Justen
2013-04-30 7:24 ` Paolo Bonzini
2013-04-29 14:00 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5183557D.9080202@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=jordan.l.justen@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).