From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYHFL-0004Hq-L6 for qemu-devel@nongnu.org; Fri, 03 May 2013 10:46:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYHFG-0007VC-If for qemu-devel@nongnu.org; Fri, 03 May 2013 10:46:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28729) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYHFG-0007Ut-2E for qemu-devel@nongnu.org; Fri, 03 May 2013 10:45:58 -0400 Message-ID: <5183C74D.4020502@redhat.com> Date: Fri, 03 May 2013 08:18:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <1367461606-7554-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1367461606-7554-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1367461606-7554-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MAQATMLHGXQTRIAIXOND" Subject: Re: [Qemu-devel] [PATCH V4 1/5] block: package preparation code in qmp_transaction() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, dietmar@proxmox.com, stefanha@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MAQATMLHGXQTRIAIXOND Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/01/2013 08:26 PM, Wenchao Xia wrote: > The code before really committing is moved into a function. Most > code are simply moved from qmp_transaction(), except that on fail it s/are/is/ > just return now. Other code such as input parsing is not touched, s/return/returns/ > to make it easier in review. >=20 > Signed-off-by: Wenchao Xia > --- > blockdev.c | 139 +++++++++++++++++++++++++++++++++-------------------= -------- > 1 files changed, 77 insertions(+), 62 deletions(-) >=20 Assuming the maintainer can correct commit messages without needing a v5.= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MAQATMLHGXQTRIAIXOND Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRg8dNAAoJEKeha0olJ0NqugAH/1KJNriuu2xwnYk4JHYWR4BC tYREVVLnNpfq3FBH8Opi99i9SpPKHf362yn5jsxTKp9jUshKRX4vG5di8SQFakSL rACJNrCOuwRFcW21pKUjqIBdt+OlwLljbLxLi8ZcPPxZGzqkYRo/trwZ9JIEk9YL QcswMpsOV0lT75yAphU2ycIZyZUTmFKbUA4Spt6zjDEDW/tpEN0J4oCNykvJAbLE YmdJLAEFl8mX3W6cwanrGZvRBK01E3cEXk631UwspO1MtynSxEXUKH7U0dDeK7M6 fwudfRIr57cB9Tl7bv5Z1mpo2na9b7nYY7BByxdOkK4wkhLqngTyr4SrLql9Dmc= =i+Ug -----END PGP SIGNATURE----- ------enig2MAQATMLHGXQTRIAIXOND--