From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYHWU-0006cq-VN for qemu-devel@nongnu.org; Fri, 03 May 2013 11:03:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYHWT-0004dd-Ma for qemu-devel@nongnu.org; Fri, 03 May 2013 11:03:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYHWT-0004dX-Ek for qemu-devel@nongnu.org; Fri, 03 May 2013 11:03:45 -0400 Message-ID: <5183D1CF.9080502@redhat.com> Date: Fri, 03 May 2013 09:03:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366657220-776-1-git-send-email-ehabkost@redhat.com> <1366657220-776-9-git-send-email-ehabkost@redhat.com> In-Reply-To: <1366657220-776-9-git-send-email-ehabkost@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GOMKMQMQIMEMESXRKSHG" Subject: Re: [Qemu-devel] [PATCH qom-cpu 8/9] target-i386: Introduce X86CPU.filtered_features field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, Igor Mammedov , Jiri Denemark , qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GOMKMQMQIMEMESXRKSHG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > This field will contain the feature bits that were filtered out because= > of missing host support. Yes, libvirt would definitely like to know that. >=20 > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu-qom.h | 3 +++ > target-i386/cpu.c | 9 ++++++--- > 2 files changed, 9 insertions(+), 3 deletions(-) >=20 Reviewed-by: Eric Blake > +++ b/target-i386/cpu.c > @@ -1642,9 +1642,12 @@ static void filter_features_for_kvm(X86CPU *cpu)= > =20 > for (w =3D 0; w < FEATURE_WORDS; w++) { > FeatureWordInfo *wi =3D &feature_word_info[w]; > - env->features[w] &=3D kvm_arch_get_supported_cpuid(s, wi->cpui= d_eax, > - wi->cpuid_= ecx, > - wi->cpuid_= reg); > + uint32_t host_feat =3D kvm_arch_get_supported_cpuid(s, wi->cpu= id_eax, > + wi->cpuid= _ecx, > + wi->cpuid= _reg); Alignment is still "interesting", but still no impact to the patch review= =2E > + uint32_t requested_features =3D env->features[w]; > + env->features[w] &=3D host_feat; > + cpu->filtered_features[w] =3D requested_features & ~env->featu= res[w]; > } > } > #endif >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GOMKMQMQIMEMESXRKSHG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRg9HPAAoJEKeha0olJ0Nqm2YH/jH3PYlge53O693f7WjZ0whZ CKaJecpmkzW8wrAAPU1zVYCuWcOg5x41K78KF5N+vw8+MsSQmoB9OwRXTQLYxn9x vwCcy49wIB6w8aSrq8ORCnyBa9sLuLG5NiFSEE9Si1nEB/IjVY/nFsvOpSDiBE0g dcjaofPmrm+U9VWgw2IQYpolouGbwkQezpv9JzZf8TnAy0f4E4HYhqt0IiB0tsqc rYQUt+vtinlUriUTxZMG353lSTe4P/hUiC7PvXrf3OLWMlKS6WdUj/lnIhj/0jVA aR/w+Xp25jc+ZvUAQc+e4uepu877yEBfhINPoJZWh8051HOVuI9ZdAUFjLJ2WjA= =KL9J -----END PGP SIGNATURE----- ------enig2GOMKMQMQIMEMESXRKSHG--