From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYYux-0004hR-9C for qemu-devel@nongnu.org; Sat, 04 May 2013 05:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYYuw-0001ig-3K for qemu-devel@nongnu.org; Sat, 04 May 2013 05:38:11 -0400 Message-ID: <5184D6FB.1090606@reactos.org> Date: Sat, 04 May 2013 11:38:03 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1367525344-7755-1-git-send-email-hpoussin@reactos.org> <1367525344-7755-8-git-send-email-hpoussin@reactos.org> <5183A13B.2030108@web.de> In-Reply-To: <5183A13B.2030108@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/7] prep: QOM'ify System I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Julio Guerra , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Andreas F=C3=A4rber a =C3=A9crit : > Am 02.05.2013 22:09, schrieb Herv=C3=A9 Poussineau: >> Most of the functionality is extracted from hw/ppc/prep.c. >> Also add support for board identification/equipment registers. >> >> Document it for the IBM 43p emulation. >> >> Cc: Julio Guerra >> Signed-off-by: Herv=C3=A9 Poussineau >> --- >> docs/ibm_43p.cfg | 5 + >> hw/ppc/Makefile.objs | 1 + >> hw/ppc/prep_systemio.c | 298 +++++++++++++++++++++++++++++++++++++++= +++++++++ >> trace-events | 4 + >> 4 files changed, 308 insertions(+) >> create mode 100644 hw/ppc/prep_systemio.c >=20 > Haven't reviewed the full patch yet, but since this is not modifying > hw/ppc/prep.c, it is duplicating code rather than QOM'ifying the > existing code. >=20 > Have you looked into Julio's patch whom you CC? I'm still not sure how > to solve things for 1.5 (and this series a consider -next). Yes, I've partly taken Julio's patch into account, ie port 0x92 is now=20 read/write. However, I didn't change the way the reset is done due to=20 missing agrement of how it should be done: "this is touching on the same=20 soft reset topic that I am awaiting the outcome for x86". [1] Moreover, registers emulated are not exactly the same as in hw/ppc/prep.c= : Registers not present in hw/ppc/prep_systemio.c: 0x800: Motorola CPU configuration register 0x802: Motorola base module feature register 0x803: Motorola base module status register 0x823: Something related to no L2 cache? Those seem specific to Motorola, so they probably belong to another devic= e. New registers added to hw/ppc/prep_systemio.c: 0x818: Key lock (Read Only) 0x852: System Board Identification (Read Only) I'm not really sure of impacts of changing 'prep' machine to remove some=20 registers and adding new ones, so I prefered to keep it as is. However,=20 if you think that I should use the QOM'ified System I/O device in 'prep'=20 machine (and this will change emulated machine), I'll do it. Herv=C3=A9 [1] https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03359.html