From: Fabien Chouteau <chouteau@adacore.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: PReP <qemu-ppc@nongnu.org>,
"hpoussin@reactos.org" <hpoussin@reactos.org>,
Alexander Graf <agraf@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH prep for-1.5 v2] prep: Add ELF support for -bios
Date: Mon, 06 May 2013 09:55:52 +0200 [thread overview]
Message-ID: <51876208.1020004@adacore.com> (raw)
In-Reply-To: <5186AC5A.3020908@web.de>
On 05/05/2013 09:00 PM, Andreas Färber wrote:
> Am 05.05.2013 20:40, schrieb Alexander Graf:
>>
>>
>> Am 05.05.2013 um 19:45 schrieb Andreas Färber <andreas.faerber@web.de>:
>>
>>> This prepares for switching from OpenHack'Ware to OpenBIOS.
>>>
>>> While touching the error handling code, switch from aborting hw_error()
>>> to fprintf()+exit() and suppress failing without -bios for qtest.
>>>
>>> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
>>
>> Acked-by: Alexander Graf <agraf@suse.de>
>
> Thanks, applied to prep-up:
> http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up
>
> Sorry, forgot the changelog:
> * error handling was split up as suggested by Alex,
> * missing exit(1) calls were added and
BTW, why do you use fprintf()+exit() instead of hw_error()?
--
Fabien Chouteau
next prev parent reply other threads:[~2013-05-06 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-05 17:45 [Qemu-devel] [PATCH prep for-1.5 v2] prep: Add ELF support for -bios Andreas Färber
2013-05-05 18:40 ` Alexander Graf
2013-05-05 19:00 ` Andreas Färber
2013-05-06 7:55 ` Fabien Chouteau [this message]
2013-05-06 16:10 ` Andreas Färber
2013-07-02 13:39 ` Julio Guerra
2013-07-02 13:53 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51876208.1020004@adacore.com \
--to=chouteau@adacore.com \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).