From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1UZGHC-0004k8-2U
	for qemu-devel@nongnu.org; Mon, 06 May 2013 03:56:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1UZGHA-0004I4-LT
	for qemu-devel@nongnu.org; Mon, 06 May 2013 03:56:01 -0400
Message-ID: <51876208.1020004@adacore.com>
Date: Mon, 06 May 2013 09:55:52 +0200
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1367775900-29706-1-git-send-email-andreas.faerber@web.de>
	<56170A62-0C96-458B-87B4-0C29F1CD4AE1@suse.de>
	<5186AC5A.3020908@web.de>
In-Reply-To: <5186AC5A.3020908@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH prep for-1.5 v2] prep: Add ELF support for
	-bios
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
Cc: PReP <qemu-ppc@nongnu.org>, "hpoussin@reactos.org" <hpoussin@reactos.org>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 05/05/2013 09:00 PM, Andreas F=C3=A4rber wrote:
> Am 05.05.2013 20:40, schrieb Alexander Graf:
>>
>>
>> Am 05.05.2013 um 19:45 schrieb Andreas F=C3=A4rber <andreas.faerber@we=
b.de>:
>>
>>> This prepares for switching from OpenHack'Ware to OpenBIOS.
>>>
>>> While touching the error handling code, switch from aborting hw_error=
()
>>> to fprintf()+exit() and suppress failing without -bios for qtest.
>>>
>>> Signed-off-by: Andreas F=C3=A4rber <andreas.faerber@web.de>
>>
>> Acked-by: Alexander Graf <agraf@suse.de>
>=20
> Thanks, applied to prep-up:
> http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up
>=20
> Sorry, forgot the changelog:
> * error handling was split up as suggested by Alex,
> * missing exit(1) calls were added and

BTW, why do you use fprintf()+exit() instead of hw_error()?

--=20
Fabien Chouteau