From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZMpN-0002k6-Pc for qemu-devel@nongnu.org; Mon, 06 May 2013 10:55:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZMpM-0006vA-6n for qemu-devel@nongnu.org; Mon, 06 May 2013 10:55:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZMdX-0002Xb-U7 for qemu-devel@nongnu.org; Mon, 06 May 2013 10:43:32 -0400 Message-ID: <5187C18D.5030901@redhat.com> Date: Mon, 06 May 2013 08:43:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1367847791-9214-1-git-send-email-john.baboval@citrix.com> In-Reply-To: <1367847791-9214-1-git-send-email-john.baboval@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2GFNOPVHFGJPAPMNQFPHX" Subject: Re: [Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Baboval Cc: "John V. Baboval" , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2GFNOPVHFGJPAPMNQFPHX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/06/2013 07:43 AM, John Baboval wrote: > From: "John V. Baboval" >=20 > This parameter will cause writes to tty backed chardevs to return > -EAGAIN if the backing tty has buffered more than the specified > number of characters. When data is sent, the TIOCOUTQ ioctl is invoked > to determine the current TTY output buffer depth. >=20 Reviewing just the interface portion of the patch: > +++ b/qapi-schema.json > @@ -3182,11 +3182,14 @@ > # > # @device: The name of the special file for the device, > # i.e. /dev/ttyS0 on Unix or COM1: on Windows > +# @maxqdepth: The maximum depth of the underlying tty > + output queue (Unix)=20 Trailing whitespace. Run your patch through scripts/checkpatch.pl. Since you are adding a new member, you should use a "(since 1.6)" comment on this line. Also, most interfaces tend to use a blank line between member documentation. > # @type: What kind of device this is. Hmm - we have a pre-existing documentation bug - this line probably should have been deleted during commit d36b2b90. > # > # Since: 1.4 > ## > -{ 'type': 'ChardevHostdev', 'data': { 'device' : 'str' } } > +{ 'type': 'ChardevHostdev', 'data': { 'device' : 'str', > + 'maxqdepth' : 'int' } } Ouch - this says that maxqdepth is mandatory. But that is a backwards-incompatible change with apps that target the 'chardev-add' QMP command of qemu 1.4. You MUST make it optional, since older apps will not be providing it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2GFNOPVHFGJPAPMNQFPHX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRh8GNAAoJEKeha0olJ0NqeyUH/R++6U5XB7IW2B24PH/tj+FC xicWXggFOGdd2AA0RDsWwGSO8C120be9Qp4Ais12LKry2+kplnTitkoECwm2Kpkh pFebot4YxD5VaeMZ2D0hSE6jlhcsucS0PELK7ILe5FPd8yTLIFak77oAP4llth4R Bz+kv8l1VTKIkWHl8duOFWxOpbwc17ckdIewxH1WmEVZVNTIKEWiXz20kyl31yH1 2a7uHzVjR35qO5XzTwJitOPny653ZTGeBX5ncADbC/it+rNEbWDCaM1T4q9sWkd3 p6qwUr79TpSqE70UCnpTGTqw1hIb09+C+pUF6jbVzwCWrMC0QjwiwmolYPYXroM= =nP/K -----END PGP SIGNATURE----- ------enig2GFNOPVHFGJPAPMNQFPHX--