From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZMkd-0007Gm-2i for qemu-devel@nongnu.org; Mon, 06 May 2013 10:50:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZMkY-0005AY-L2 for qemu-devel@nongnu.org; Mon, 06 May 2013 10:50:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58817 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZMkY-0005AK-3v for qemu-devel@nongnu.org; Mon, 06 May 2013 10:50:46 -0400 Message-ID: <5187C342.2050802@suse.de> Date: Mon, 06 May 2013 16:50:42 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC][PATCH 00/15] Refactor portio dispatching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Paolo Bonzini , Liu Ping Fan , malc , qemu-devel , =?ISO-8859-15?Q?Herv=E9_Poussineau?= Am 06.05.2013 16:26, schrieb Jan Kiszka: > This series converts the remaining users of register_ioport* to portio > lists, Why does it need to be lists? Is there anything wrong with using isa_register_ioport() as done in Herv=E9's previous ioport cleanup series= ? (Hope you were aware of those ppc-centered discussions?) Andreas > simplifies the handling of subpages and adds support for unaligned > memory region accesses. Then it replaces the current portio dispatcher > with the existing one for MMIO and removes several lines of code. This > also allows to build BQL-free portio on top once we enhance the memory > layer accordingly. >=20 > Seems to work fine so far but surely requires thorough review. And I > would welcome early comments on the direction. >=20 > Jan >=20 >=20 > CC: malc >=20 > Jan Kiszka (15): > adlib: replace register_ioport* > applesmc: replace register_ioport* > wdt_ib700: replace register_ioport* > i82374: replace register_ioport* > prep: replace register_ioport* > vt82c686: replace register_ioport* > Privatize register_ioport_read/write > isa: implement isa_is_ioport_assigned via memory_region_find > memory: Introduce address_space_lookup_region > memory: Rework sub-page handling > memory: Allow unaligned address_space_rw > vmware-vga: Accept unaligned I/O accesses > ioport: Switch dispatching to memory core layer > ioport: Remove unused old dispatching services > ioport: Move IOPortRead/WriteFunc typedefs to memory.h >=20 > cputlb.c | 2 +- > exec.c | 273 +++++++++++++-------------------= ----- > hw/acpi/piix4.c | 6 +- > hw/audio/adlib.c | 20 ++- > hw/display/vmware_vga.c | 4 + > hw/dma/i82374.c | 17 ++- > hw/isa/isa-bus.c | 11 ++ > hw/isa/lpc_ich9.c | 8 +- > hw/isa/vt82c686.c | 40 ++++-- > hw/misc/applesmc.c | 48 +++++-- > hw/ppc/prep.c | 23 ++- > hw/watchdog/wdt_ib700.c | 12 ++- > include/exec/cputlb.h | 2 - > include/exec/ioport.h | 19 +--- > include/exec/iorange.h | 31 ---- > include/exec/memory-internal.h | 2 - > include/exec/memory.h | 26 ++-- > include/hw/isa/isa.h | 2 + > ioport.c | 294 ++++----------------------------= -------- > memory.c | 102 +++++--------- > translate-all.c | 3 +- > 21 files changed, 311 insertions(+), 634 deletions(-) > delete mode 100644 include/exec/iorange.h >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg