From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54044)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZOFA-0004Wb-2E
	for qemu-devel@nongnu.org; Mon, 06 May 2013 12:26:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZOF9-0006JW-0r
	for qemu-devel@nongnu.org; Mon, 06 May 2013 12:26:27 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5187D9A6.6050807@redhat.com>
Date: Mon, 06 May 2013 18:26:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5187D529.7010502@siemens.com>
In-Reply-To: <5187D529.7010502@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] memory: Replace open-coded
	memory_region_is_romd
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>

Il 06/05/2013 18:07, Jan Kiszka ha scritto:
> Improves readability.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  translate-all.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/translate-all.c b/translate-all.c
> index da93608..0d84b0d 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr)
>      section = phys_page_find(address_space_memory.dispatch,
>                               addr >> TARGET_PAGE_BITS);
>      if (!(memory_region_is_ram(section->mr)
> -          || (section->mr->rom_device && section->mr->readable))) {
> +          || memory_region_is_romd(section->mr))) {
>          return;
>      }
>      ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK)
> 

Not trivial enough for qemu-trivial, let's open a memory branch for 1.6.

Any volunteers for co-maintaining it? :)

Paolo