From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZQ37-0002f9-HV for qemu-devel@nongnu.org; Mon, 06 May 2013 14:22:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZQ35-0006aW-Ar for qemu-devel@nongnu.org; Mon, 06 May 2013 14:22:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40892 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZQ35-0006aE-1n for qemu-devel@nongnu.org; Mon, 06 May 2013 14:22:07 -0400 Message-ID: <5187F4CB.9070105@suse.de> Date: Mon, 06 May 2013 20:22:03 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1367424440-16687-1-git-send-email-afaerber@suse.de> In-Reply-To: <1367424440-16687-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, imammedo@redhat.com, anthony@codemonkey.ws, "H. Peter Anvin" , pbonzini@redhat.com, Borislav Petkov Am 01.05.2013 18:07, schrieb Andreas F=C3=A4rber: > Hello, >=20 > It's easier adapting the infrastructure to our needs than working aroun= d it: > X86CPU already has QOM properties today. What's lacking is model subcla= sses, > and with the one X86CPU type its global properties are overwritten by m= odels. > But we already know the designated naming scheme for the models! >=20 > So let's simply prepare compat_props for CPU models and make sure they = are > already picked up today. >=20 > This works just fine for changing the 486 CPUID model value and avoids = to > redo the PC part once we have X86CPU subclasses. > Tested using: ./QMP/qom-get /machine/icc-bridge/icc/child[0].model >=20 > For changing n270 CPUID flags we'll still need to resort to Eduardo's p= roposed > helper functions for now. >=20 > Regards, > Andreas >=20 > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: H. Peter Anvin > Cc: Borislav Petkov > Cc: Anthony Liguori > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin >=20 > Andreas F=C3=A4rber (4): > qdev: Let qdev_prop_parse() pass through Error > qdev: Introduce qdev_prop_set_custom_globals() > target-i386: Emulate X86CPU subclasses for global properties > target-i386: Change CPUID model of 486 to 8 Hearing no veto from Anthony on IRC, I have applied these to qom-cpu (with helper function renamed): https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas >=20 > hw/core/qdev-properties.c | 50 ++++++++++++++++++++++++++----------= -------- > hw/core/qdev.c | 7 ++++++- > include/hw/i386/pc.h | 4 ++++ > include/hw/qdev-properties.h | 7 +++++-- > qdev-monitor.c | 6 +++++- > target-i386/cpu.c | 11 +++++++++- > 6 files changed, 60 insertions(+), 25 deletions(-) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg