From: Richard Henderson <rth@twiddle.net>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state
Date: Wed, 28 Dec 2016 08:08:33 -0800 [thread overview]
Message-ID: <5187c1b7-1c34-1cc1-1e22-9d1f957d6e82@twiddle.net> (raw)
In-Reply-To: <148293408387.28901.10687132341063477318.stgit@fimbulvetr.bsc.es>
On 12/28/2016 06:08 AM, Lluís Vilanova wrote:
> @@ -83,6 +85,13 @@ uint32_t tb_hash_func5(uint64_t a0, uint64_t b0, uint32_t e)
> h32 += e * PRIME32_3;
> h32 = rol32(h32, 17) * PRIME32_4;
>
> + if (sizeof(TRACE_QHT_VCPU_DSTATE_TYPE) == sizeof(uint32_t)) {
> + h32 += f * PRIME32_3;
> + h32 = rol32(h32, 17) * PRIME32_4;
> + } else {
> + abort();
> + }
> +
QEMU_BUILD_BUG_ON.
r~
next prev parent reply other threads:[~2016-12-28 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 14:07 [Qemu-devel] [PATCH v5 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches Lluís Vilanova
2016-12-28 14:07 ` [Qemu-devel] [PATCH v5 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache Lluís Vilanova
2016-12-28 14:07 ` [Qemu-devel] [PATCH v5 2/7] trace: Make trace_get_vcpu_event_count() inlinable Lluís Vilanova
2016-12-28 14:07 ` [Qemu-devel] [PATCH v5 3/7] trace: [tcg] Delay changes to dynamic state when translating Lluís Vilanova
2016-12-28 14:08 ` [Qemu-devel] [PATCH v5 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state Lluís Vilanova
2016-12-28 16:08 ` Richard Henderson [this message]
2016-12-28 16:23 ` Lluís Vilanova
2016-12-28 14:08 ` [Qemu-devel] [PATCH v5 5/7] trace: [tcg] Do not generate TCG code to trace dinamically-disabled events Lluís Vilanova
2016-12-28 14:08 ` [Qemu-devel] [PATCH v5 6/7] trace: [tcg, trivial] Re-align generated code Lluís Vilanova
2016-12-28 14:08 ` [Qemu-devel] [PATCH v5 7/7] trace: [trivial] Statically enable all guest events Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5187c1b7-1c34-1cc1-1e22-9d1f957d6e82@twiddle.net \
--to=rth@twiddle.net \
--cc=crosthwaite.peter@gmail.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).