From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZRjR-0001v6-Bk for qemu-devel@nongnu.org; Mon, 06 May 2013 16:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZRjP-0002GN-CG for qemu-devel@nongnu.org; Mon, 06 May 2013 16:09:56 -0400 Received: from mail-ea0-x233.google.com ([2a00:1450:4013:c01::233]:50890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZRjP-0002GG-5z for qemu-devel@nongnu.org; Mon, 06 May 2013 16:09:55 -0400 Received: by mail-ea0-f179.google.com with SMTP id h14so1877243eaj.24 for ; Mon, 06 May 2013 13:09:54 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51880E09.6030406@redhat.com> Date: Mon, 06 May 2013 22:09:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <29d07f201f1ae231f543e8884c0eb67278b105e1.1367849167.git.jan.kiszka@siemens.com> In-Reply-To: <29d07f201f1ae231f543e8884c0eb67278b105e1.1367849167.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Liu Ping Fan , qemu-devel , =?ISO-8859-1?Q?Andreas_F=E4rber?= Il 06/05/2013 16:26, Jan Kiszka ha scritto: > Simplify the sub-page handling by implementing it directly in the > dispatcher instead of using a redirection memory region. We extend the > phys_sections entries to optionally hold a pointer to the sub-section > table that used to reside in the subpage_t structure. IOW, we add one > optional dispatch level below the existing radix tree. > > address_space_lookup_region is extended to take this additional level > into account. This direct dispatching to that target memory region will > also be helpful when we want to add per-region locking control. > > Signed-off-by: Jan Kiszka I wonder if subpage_ram is needed at all now. Should be a separate patch anyway, so Reviewed-by: Paolo Bonzini