From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZS8P-0004me-On for qemu-devel@nongnu.org; Mon, 06 May 2013 16:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZS8K-0002pk-R6 for qemu-devel@nongnu.org; Mon, 06 May 2013 16:35:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47819 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZS8K-0002pd-HQ for qemu-devel@nongnu.org; Mon, 06 May 2013 16:35:40 -0400 Message-ID: <51881418.8080206@suse.de> Date: Mon, 06 May 2013 22:35:36 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366915386-14728-1-git-send-email-ehabkost@redhat.com> <1366915386-14728-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1366915386-14728-6-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 5/7] target-i386: n270 can MOVBE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Borislav Petkov Cc: Igor Mammedov , "H. Peter Anvin" , qemu-devel@nongnu.org, Richard Henderson Am 25.04.2013 20:43, schrieb Eduardo Habkost: > From: Borislav Petkov >=20 > The Atom core (cpu name "n270" in QEMU speak) supports MOVBE. This is > needed when booting 3.8 and later linux kernels built with the MATOM > target because we require MOVBE in order to boot properly now. >=20 > Cc: "H. Peter Anvin" > Cc: Richard Henderson > Signed-off-by: Borislav Petkov > [ehabkost: added compat code to disable MOVBE on pc-*-1.4 and older] > Signed-off-by: Eduardo Habkost > --- > hw/i386/pc_piix.c | 1 + > hw/i386/pc_q35.c | 1 + > target-i386/cpu.c | 3 ++- > 3 files changed, 4 insertions(+), 1 deletion(-) Thanks, rebased and applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 20708dc..615d8f4 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -237,6 +237,7 @@ static void pc_init_pci(QEMUMachineInitArgs *args) > =20 > static void pc_init_pci_1_4(QEMUMachineInitArgs *args) > { > + x86_cpu_compat_set_features("n270", FEAT_1_ECX, 0, CPUID_EXT_MOVBE= ); > pc_init_pci(args); > } > =20 > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 7eb4a75..3240203 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -211,6 +211,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args) > =20 > static void pc_q35_init_1_4(QEMUMachineInitArgs *args) > { > + x86_cpu_compat_set_features("n270", FEAT_1_ECX, 0, CPUID_EXT_MOVBE= ); > pc_q35_init(args); > } > =20 > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 8ce088e..592fed8 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -656,7 +656,8 @@ static x86_def_t builtin_x86_defs[] =3D { > /* Some CPUs got no CPUID_SEP */ > .features[FEAT_1_ECX] =3D > CPUID_EXT_SSE3 | CPUID_EXT_MONITOR | CPUID_EXT_SSSE3 | > - CPUID_EXT_DSCPL | CPUID_EXT_EST | CPUID_EXT_TM2 | CPUID_EX= T_XTPR, > + CPUID_EXT_DSCPL | CPUID_EXT_EST | CPUID_EXT_TM2 | CPUID_EX= T_XTPR | > + CPUID_EXT_MOVBE, > .features[FEAT_8000_0001_EDX] =3D > (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) | > CPUID_EXT2_NX, >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg