From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZZhg-0000lV-UW for qemu-devel@nongnu.org; Tue, 07 May 2013 00:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZZhg-00064G-27 for qemu-devel@nongnu.org; Tue, 07 May 2013 00:40:40 -0400 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:43508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZZhf-000642-QA for qemu-devel@nongnu.org; Tue, 07 May 2013 00:40:39 -0400 Received: by mail-we0-f179.google.com with SMTP id t59so31125wes.24 for ; Mon, 06 May 2013 21:40:39 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <518885BD.5030404@redhat.com> Date: Tue, 07 May 2013 06:40:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <87wqrci2zs.fsf@codemonkey.ws> <87r4hj4zqg.fsf@codemonkey.ws> <5188157F.1080302@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: Anthony Liguori , qemu-devel , Gleb Natapov Il 06/05/2013 23:07, Jordan Justen ha scritto: > On Mon, May 6, 2013 at 1:41 PM, Paolo Bonzini wrote: >> Il 06/05/2013 22:31, Anthony Liguori ha scritto: >>> Jordan Justen writes: >>> >>>> On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: >>>>> I believe I have processed all of the outstanding pull requests and >>>>> patches tagged for 1.5. If there are any other patches or pull requests >>>>> you would like to be considered, please respond to this note with a >>>>> pointer to the patch or make sure you send it out tagged with 'for-1.5' >>>>> no later than 5pm US/Eastern. >>>> >>>> Is there a chance of including the KVM PC flash series in 1.5? >>>> Unfortunately, I'm assuming no given the timing. >>> >>> I think we're going to need to delay it. Did we ever come to a >>> consensus about what to do on older kernels? >> >> Yes, the patches only use the new feature is -pflash is given on the >> command line. memory_region_set_readonly is only used in a few places, >> so I think this series could go in; it is a fix for a TCG-mode regression. >> >> I'm curious however if it causes -M isapc to regress, because in 1.4 it >> works only in KVM mode, not in TCG mode. > > It looks like isapc has always set rom_only to 1, meaning it never > should have supported PC flash. So, I hope isapc didn't ever have any > noticeable behavior change due to the PC flash feature. The change would be because you now implement memory_region_set_readonly. That's the "dangerous" part of the series. Paolo