From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57804)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andre.przywara@linaro.org>) id 1UZhOH-0008Rd-Cr
	for qemu-devel@nongnu.org; Tue, 07 May 2013 08:53:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andre.przywara@linaro.org>) id 1UZhOE-0000xf-LC
	for qemu-devel@nongnu.org; Tue, 07 May 2013 08:53:09 -0400
Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:58383)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andre.przywara@linaro.org>) id 1UZhOE-0000xY-Hr
	for qemu-devel@nongnu.org; Tue, 07 May 2013 08:53:06 -0400
Received: by mail-qc0-f169.google.com with SMTP id z10so251613qcx.0
	for <qemu-devel@nongnu.org>; Tue, 07 May 2013 05:53:06 -0700 (PDT)
Message-ID: <5188F916.5070500@linaro.org>
Date: Tue, 07 May 2013 14:52:38 +0200
From: Andre Przywara <andre.przywara@linaro.org>
MIME-Version: 1.0
References: <1367930219-14361-1-git-send-email-andre.przywara@linaro.org>
	<CAFEAcA-GbfQAUn-ZePPjHyM4X4P50Lm=aXGOY9E5Xe9r4VtA9Q@mail.gmail.com>
In-Reply-To: <CAFEAcA-GbfQAUn-ZePPjHyM4X4P50Lm=aXGOY9E5Xe9r4VtA9Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fdt: update embedded header file from
 upstream to fix compilation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, kim.phillips@freescale.com, jdl@jdl.com, hollisb@us.ibm.com, qemu-devel@nongnu.org

On 05/07/2013 02:44 PM, Peter Maydell wrote:
> On 7 May 2013 13:36, Andre Przywara <andre.przywara@linaro.org> wrote:
>> Upstream dtc.git introduced a change in libfdt_env.h, which breaks
>> compilation with QEMU's version of it:
>>
>>    CC arm-softmmu/device_tree.o
>> In file included from /usr/include/libfdt.h:55:0,
>>                   from /src/qemu.git/device_tree.c:28:
>> /usr/include/fdt.h:7:2: error: unknown type name 'fdt32_t'
>>     ...
>
> I'm not entirely sure I understand why we need change.
> Have upstream really introduced a breaking change for
> everybody who uses libfdt, or are we using it wrongly?

Everybody who copies and changes a header from the original distribution 
and uses this now instead of the installed version ;-)

libfdt (or better: dtc) seems to be quite out of date in the official 
distribution packages. I just happened to have git HEAD installed manually.

Regards,
Andre.