From: Andre Przywara <andre.przywara@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, kim.phillips@freescale.com, jdl@jdl.com,
hollisb@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fdt: update embedded header file from upstream to fix compilation
Date: Tue, 07 May 2013 16:00:31 +0200 [thread overview]
Message-ID: <518908FF.6010208@linaro.org> (raw)
In-Reply-To: <CAFEAcA80EquqVFjarKKL2fFc2+Ava9Jzbn6yHqyb8-TVLFiPeg@mail.gmail.com>
On 05/07/2013 03:24 PM, Peter Maydell wrote:
> On 7 May 2013 13:52, Andre Przywara <andre.przywara@linaro.org> wrote:
>> On 05/07/2013 02:44 PM, Peter Maydell wrote:
>>> I'm not entirely sure I understand why we need change.
>>> Have upstream really introduced a breaking change for
>>> everybody who uses libfdt, or are we using it wrongly?
>>
>>
>> Everybody who copies and changes a header from the original distribution and
>> uses this now instead of the installed version ;-)
>
> Right, but the distro libfdt-dev package doesn't ship with
> libfdt_env.h, so presumably the expectation is that users
> of libfdt copy and adjust it, and so the set of things it
> has to provide is part of the "public" interface?
Seems to be true for the CentOS package for instance, but not for Wheezy:
http://packages.debian.org/wheezy/amd64/libfdt-dev/filelist
Also "make install" on the source distribution copies the file to
/usr/include. Even if I delete it, fdt.h still references fdt32_t, so I
get the same error again.
Regards,
Andre.
prev parent reply other threads:[~2013-05-07 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 12:36 [Qemu-devel] [PATCH] fdt: update embedded header file from upstream to fix compilation Andre Przywara
2013-05-07 12:44 ` Peter Maydell
2013-05-07 12:52 ` Andre Przywara
2013-05-07 13:24 ` Peter Maydell
2013-05-07 14:00 ` Andre Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518908FF.6010208@linaro.org \
--to=andre.przywara@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=jdl@jdl.com \
--cc=kim.phillips@freescale.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).