From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andre.przywara@linaro.org>) id 1UZiRz-0007FF-PD
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:01:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andre.przywara@linaro.org>) id 1UZiRw-0008OR-OU
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:01:03 -0400
Received: from mail-vb0-x22e.google.com ([2607:f8b0:400c:c02::22e]:39511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andre.przywara@linaro.org>) id 1UZiRw-0008OM-Jm
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:01:00 -0400
Received: by mail-vb0-f46.google.com with SMTP id 10so485298vbe.5
	for <qemu-devel@nongnu.org>; Tue, 07 May 2013 07:01:00 -0700 (PDT)
Message-ID: <518908FF.6010208@linaro.org>
Date: Tue, 07 May 2013 16:00:31 +0200
From: Andre Przywara <andre.przywara@linaro.org>
MIME-Version: 1.0
References: <1367930219-14361-1-git-send-email-andre.przywara@linaro.org>
	<CAFEAcA-GbfQAUn-ZePPjHyM4X4P50Lm=aXGOY9E5Xe9r4VtA9Q@mail.gmail.com>
	<5188F916.5070500@linaro.org>
	<CAFEAcA80EquqVFjarKKL2fFc2+Ava9Jzbn6yHqyb8-TVLFiPeg@mail.gmail.com>
In-Reply-To: <CAFEAcA80EquqVFjarKKL2fFc2+Ava9Jzbn6yHqyb8-TVLFiPeg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fdt: update embedded header file from
 upstream to fix compilation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, kim.phillips@freescale.com, jdl@jdl.com, hollisb@us.ibm.com, qemu-devel@nongnu.org

On 05/07/2013 03:24 PM, Peter Maydell wrote:
> On 7 May 2013 13:52, Andre Przywara <andre.przywara@linaro.org> wrote:
>> On 05/07/2013 02:44 PM, Peter Maydell wrote:
>>> I'm not entirely sure I understand why we need change.
>>> Have upstream really introduced a breaking change for
>>> everybody who uses libfdt, or are we using it wrongly?
>>
>>
>> Everybody who copies and changes a header from the original distribution and
>> uses this now instead of the installed version ;-)
>
> Right, but the distro libfdt-dev package doesn't ship with
> libfdt_env.h, so presumably the expectation is that users
> of libfdt copy and adjust it, and so the set of things it
> has to provide is part of the "public" interface?

Seems to be true for the CentOS package for instance, but not for Wheezy:
http://packages.debian.org/wheezy/amd64/libfdt-dev/filelist

Also "make install" on the source distribution copies the file to 
/usr/include. Even if I delete it, fdt.h still references fdt32_t, so I 
get the same error again.

Regards,
Andre.