From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZiqf-0000UE-H8 for qemu-devel@nongnu.org; Tue, 07 May 2013 10:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZiqa-0000Zn-TJ for qemu-devel@nongnu.org; Tue, 07 May 2013 10:26:33 -0400 Message-ID: <51890D04.7030102@siemens.com> Date: Tue, 07 May 2013 16:17:40 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <5187D529.7010502@siemens.com> <5187D9A6.6050807@redhat.com> In-Reply-To: <5187D9A6.6050807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: Replace open-coded memory_region_is_romd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-trivial , qemu-devel On 2013-05-06 18:26, Paolo Bonzini wrote: > Il 06/05/2013 18:07, Jan Kiszka ha scritto: >> Improves readability. >> >> Signed-off-by: Jan Kiszka >> --- >> translate-all.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/translate-all.c b/translate-all.c >> index da93608..0d84b0d 100644 >> --- a/translate-all.c >> +++ b/translate-all.c >> @@ -1359,7 +1359,7 @@ void tb_invalidate_phys_addr(hwaddr addr) >> section = phys_page_find(address_space_memory.dispatch, >> addr >> TARGET_PAGE_BITS); >> if (!(memory_region_is_ram(section->mr) >> - || (section->mr->rom_device && section->mr->readable))) { >> + || memory_region_is_romd(section->mr))) { >> return; >> } >> ram_addr = (memory_region_get_ram_addr(section->mr) & TARGET_PAGE_MASK) >> > > Not trivial enough for qemu-trivial, let's open a memory branch for 1.6. Great, thanks. > > Any volunteers for co-maintaining it? :) Raising my hand, but not without remarking that I have some bandwidth issue ATM. But I will try my best. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux