qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	aik@ozlabs.ru, jan.kiszka@siemens.com, qemu-devel@nongnu.org,
	qemulist@gmail.com, Avi Kivity <avi.kivity@gmail.com>,
	stefanha@redhat.com, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH 00/40] Memory-related changes sneak peek for 1.6
Date: Tue, 07 May 2013 16:54:20 +0200	[thread overview]
Message-ID: <5189159C.2040706@redhat.com> (raw)
In-Reply-To: <CAFEAcA81RGTpbkbht8bWEPREyuEuENuTvcr0byZTgYnp7cHadw@mail.gmail.com>

Il 07/05/2013 16:46, Peter Maydell ha scritto:
> On 7 May 2013 15:16, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> These patches are also at git://github.com/bonzini/qemu.git, branch
>> iommu.
> 
> A number of the patches in this series have checkpatch issues,
> mostly but not exclusively over-long lines.

ERROR: space prohibited before open square bracket '['
#2157: FILE: hw/ppc/spapr_iommu.c:106:
+        .perm = { [0] = tce & SPAPR_TCE_RO, [1] = tce & SPAPR_TCE_WO },

False positive.


ERROR: do not use assignment in if condition
#3313: FILE: hw/ide/ahci.c:660:
+    if (!(prdt = dma_memory_map(ad->hba->as, prdt_addr, &prdt_len,

Pre-existing, in a large mechanical patch.  Will not fix.


ERROR: spaces required around that '?' (ctx:VxV)
#4298: FILE: memory.c:1600:
+    as->name = g_strdup(name?name:"anonymous");
                             ^

ERROR: spaces required around that ':' (ctx:VxV)
#4298: FILE: memory.c:1600:
+    as->name = g_strdup(name?name:"anonymous");
                                  ^

Will fix.


ERROR: need consistent spacing around '*' (ctx:WxV)
#4399: FILE: memory.c:1044:
+Object *memory_region_owner(MemoryRegion *mr)
        ^

False positive.


ERROR: "foo * bar" should be "foo *bar"
#5224: FILE: hw/display/cirrus_vga.c:2809:
+static void cirrus_init_common(CirrusVGAState * s, int device_id,

Will fix.

Paolo

  reply	other threads:[~2013-05-07 14:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07 14:16 [Qemu-devel] [PATCH 00/40] Memory-related changes sneak peek for 1.6 Paolo Bonzini
2013-05-07 14:46 ` Peter Maydell
2013-05-07 14:54   ` Paolo Bonzini [this message]
2013-05-07 18:51 ` Peter Maydell
2013-05-07 20:21   ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2013-05-07 14:16 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5189159C.2040706@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=avi.kivity@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=jan.kiszka@siemens.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemulist@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).