From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZjHk-00017h-So
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:54:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZjHj-0003sK-M8
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:54:32 -0400
Received: from mail-gg0-x235.google.com ([2607:f8b0:4002:c02::235]:61734)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZjHj-0003sB-Hm
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:54:31 -0400
Received: by mail-gg0-f181.google.com with SMTP id q1so132934ggm.26
	for <qemu-devel@nongnu.org>; Tue, 07 May 2013 07:54:30 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5189159C.2040706@redhat.com>
Date: Tue, 07 May 2013 16:54:20 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367936209-12109-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA81RGTpbkbht8bWEPREyuEuENuTvcr0byZTgYnp7cHadw@mail.gmail.com>
In-Reply-To: <CAFEAcA81RGTpbkbht8bWEPREyuEuENuTvcr0byZTgYnp7cHadw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/40] Memory-related changes sneak peek
	for 1.6
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, aik@ozlabs.ru, jan.kiszka@siemens.com, qemu-devel@nongnu.org, qemulist@gmail.com, Avi Kivity <avi.kivity@gmail.com>, stefanha@redhat.com, david@gibson.dropbear.id.au

Il 07/05/2013 16:46, Peter Maydell ha scritto:
> On 7 May 2013 15:16, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> These patches are also at git://github.com/bonzini/qemu.git, branch
>> iommu.
> 
> A number of the patches in this series have checkpatch issues,
> mostly but not exclusively over-long lines.

ERROR: space prohibited before open square bracket '['
#2157: FILE: hw/ppc/spapr_iommu.c:106:
+        .perm = { [0] = tce & SPAPR_TCE_RO, [1] = tce & SPAPR_TCE_WO },

False positive.


ERROR: do not use assignment in if condition
#3313: FILE: hw/ide/ahci.c:660:
+    if (!(prdt = dma_memory_map(ad->hba->as, prdt_addr, &prdt_len,

Pre-existing, in a large mechanical patch.  Will not fix.


ERROR: spaces required around that '?' (ctx:VxV)
#4298: FILE: memory.c:1600:
+    as->name = g_strdup(name?name:"anonymous");
                             ^

ERROR: spaces required around that ':' (ctx:VxV)
#4298: FILE: memory.c:1600:
+    as->name = g_strdup(name?name:"anonymous");
                                  ^

Will fix.


ERROR: need consistent spacing around '*' (ctx:WxV)
#4399: FILE: memory.c:1044:
+Object *memory_region_owner(MemoryRegion *mr)
        ^

False positive.


ERROR: "foo * bar" should be "foo *bar"
#5224: FILE: hw/display/cirrus_vga.c:2809:
+static void cirrus_init_common(CirrusVGAState * s, int device_id,

Will fix.

Paolo