From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZlVv-0000lt-E6 for qemu-devel@nongnu.org; Tue, 07 May 2013 13:17:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZlVt-0006NK-Ql for qemu-devel@nongnu.org; Tue, 07 May 2013 13:17:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZlVt-0006N7-IR for qemu-devel@nongnu.org; Tue, 07 May 2013 13:17:17 -0400 Message-ID: <5189371A.5020007@redhat.com> Date: Tue, 07 May 2013 11:17:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <5187C18D.5030901@redhat.com> <1367945514-20608-1-git-send-email-john.baboval@citrix.com> <1367945514-20608-2-git-send-email-john.baboval@citrix.com> In-Reply-To: <1367945514-20608-2-git-send-email-john.baboval@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2VMESRHIKCWOEEDXOURLM" Subject: Re: [Qemu-devel] [PATCH] Add 'maxqdepth' as an option to tty character devices. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Baboval Cc: "John V. Baboval" , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2VMESRHIKCWOEEDXOURLM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/07/2013 10:51 AM, John Baboval wrote: > From: "John V. Baboval" >=20 > This parameter will cause writes to tty backed chardevs to return > -EAGAIN if the backing tty has buffered more than the specified > number of characters. When data is sent, the TIOCOUTQ ioctl is invoked > to determine the current TTY output buffer depth. When submitting a v2 patch, please adjust the subject line to call out that it is a v2, and send it as a top-level thread rather than in-reply-to an earlier thread. For more details, see: http://wiki.qemu.org/Contribute/SubmitAPatch > +++ b/qapi-schema.json > @@ -3182,11 +3182,14 @@ > # > # @device: The name of the special file for the device, > # i.e. /dev/ttyS0 on Unix or COM1: on Windows > +# @maxqdepth: The maximum depth of the underlying tty > + output queue (Unix)=20 > # @type: What kind of device this is. > # > # Since: 1.4 > ## > -{ 'type': 'ChardevHostdev', 'data': { 'device' : 'str' } } > +{ 'type': 'ChardevHostdev', 'data': { 'device' : 'str', > + 'maxqdepth' : 'int' } } You did not address any of my review concerns from v1, such as listing a (since 1.6) label or marking maxqdepth as optional. Are you sure you sent the right patch? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2VMESRHIKCWOEEDXOURLM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRiTcaAAoJEKeha0olJ0NqM88H/RYxy4jZV38Ztjh2BeGEXc7p 3YpIUxfhXXyk8wVA0SrntIRKpPTZc0sAzMYDn4xkHlqTfM1/q4mTPI3BnwrdyY83 R559eKnD5N6agLJA2YmhcA/PSROTKQzIcyeCJ5tWH9iWo1iGfoh3hfg5vreIOFAM 0ObebM9z5G4eY7vROvm9spojamO95n5rtBeVsdUy94+aPgWYnv0UTr6rTCJPdyUH gmR3Dgdvm3B/yLpa+xwXMej8Y0BcqwW4xYp9nAaCLm+lE/nSz/YvzZZ4ScTm4Adq 9XuUC5PASv52GinirqFWCrwE4HL6Uv30pO+A5CIIbPSsXznfyo2dX0tfkQHOWg4= =z1Rz -----END PGP SIGNATURE----- ------enig2VMESRHIKCWOEEDXOURLM--