From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua7yl-0000dE-Bs for qemu-devel@nongnu.org; Wed, 08 May 2013 13:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ua7yk-0004zR-5z for qemu-devel@nongnu.org; Wed, 08 May 2013 13:16:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua7yj-0004zK-Se for qemu-devel@nongnu.org; Wed, 08 May 2013 13:16:34 -0400 Message-ID: <518A886D.6080105@redhat.com> Date: Wed, 08 May 2013 11:16:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1367911007-13990-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1367911007-13990-10-git-send-email-qiaonuohan@cn.fujitsu.com> <5189362E.3030707@redhat.com> <004301ce4bc9$11040970$330c1c50$@cn.fujitsu.com> In-Reply-To: <004301ce4bc9$11040970$330c1c50$@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2WMVKFQEVHBPCNSPEWMUN" Subject: Re: [Qemu-devel] [PATCH 9/9] Make monitor command 'dump-guest-memory' dump in kdump-compressed format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qiaonuohan Cc: 'Zhang Xiaohe' , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WMVKFQEVHBPCNSPEWMUN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/08/2013 02:50 AM, qiaonuohan wrote: >=20 > Thanks for your suggestion. I will fix it like: >=20 > { 'enum': 'DumpCompressionFormat', > 'data': [ 'zlib', 'lzo', 'snappy' ] } >=20 > For zlib is treated as the default compression format, and > 'uncompressed' won't be an option. No, I was serious that you need to provide 'uncompressed' as an explicit enum value. It is very annoying to toggle between four states (three compression formats and a fourth state of no compression) when the fourth is available only by omitting a parameter. The default MUST be 'uncompressed' for backwards-compatibility, not 'zlib'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2WMVKFQEVHBPCNSPEWMUN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRiohtAAoJEKeha0olJ0NqjwgH/0+T6+0R9Hb0ujoshByFPhPR kP/MKf3jTDvz+vidLNvdoN9oGQNBEaorYrpPlnKuRtMbdA8riRw88nCtTsm4fymh 1AVWPlHsgvsBpsp88zP4u9v8cda6i6EMJYHNUnnIQ4ntxQzFDWlCd8QGbUmq0nPW hHDeQCCztYexDvQ8I38vtKygFSasf2vWZ6PJ7sI00jp1ma9NN1nUmeNFoUvHCHcu tGYwfohW79+J6YCuyM99IFWlgSkBuEsypO6shlhFw3sdM/yDSHJrpiIpbOBLTtLW bUK5mGQQXoPoZFVS/oPweaEbIISkJmGvSBq7pS3/HbIoJ92li6M3YTK1owoJA3o= =PKmD -----END PGP SIGNATURE----- ------enig2WMVKFQEVHBPCNSPEWMUN--