From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaGSP-0004TI-Rk for qemu-devel@nongnu.org; Wed, 08 May 2013 22:19:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaGSO-0002oy-W5 for qemu-devel@nongnu.org; Wed, 08 May 2013 22:19:45 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:35747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaGSO-0002op-PM for qemu-devel@nongnu.org; Wed, 08 May 2013 22:19:44 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 May 2013 20:19:43 -0600 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 003543E4003F for ; Wed, 8 May 2013 20:19:26 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r492JfJS133714 for ; Wed, 8 May 2013 20:19:41 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r492JeDk024130 for ; Wed, 8 May 2013 20:19:40 -0600 Message-ID: <518B07B8.8020207@linux.vnet.ibm.com> Date: Thu, 09 May 2013 10:19:36 +0800 From: Dong Xu Wang MIME-Version: 1.0 References: <1368002735-3646-1-git-send-email-wdongxu@linux.vnet.ibm.com> <1368002735-3646-7-git-send-email-wdongxu@linux.vnet.ibm.com> <518A9286.2040603@redhat.com> In-Reply-To: <518A9286.2040603@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V14 6/6] remove QEMUOptionParameter related functions and struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: "kwolf@redhat.com" , wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com On 2013/5/9 1:59, Eric Blake wrote: > [assuming you mis-typed your cc:, and that you meant kwolf instead of > kwol at redhat] > > On 05/08/2013 02:45 AM, Dong Xu Wang wrote: >> Signed-off-by: Dong Xu Wang >> --- >> include/qemu/option.h | 32 ------ >> util/qemu-option.c | 285 ----- --------------------------------------------- >> 2 files changed, 317 deletions(-) >> >> diff --git a/include/qemu/option.h b/include/qemu/option.h >> index d63e447..51814cf 100644 >> --- a/include/qemu/option.h >> +++ b/include/qemu/option.h >> @@ -38,17 +38,6 @@ enum QEMUOptionParType { >> OPT_STRING, >> }; >> >> -typedef struct QEMUOptionParameter { >> - const char *name; >> - enum QEMUOptionParType type; > > 'enum QEMUOptionParType' several lines earlier is now unused; you should > clean that too. > Yes, will remove it after reviewing, thank you, Eric.