From: Paolo Bonzini <pbonzini@redhat.com>
To: liu ping fan <qemulist@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <anthony@codemonkey.ws>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm
Date: Thu, 09 May 2013 16:58:12 +0200 [thread overview]
Message-ID: <518BB984.10200@redhat.com> (raw)
In-Reply-To: <CAJnKYQnLtDjcowkrA0mzkcmX27+r2EQThvStCeb2CKGjUfKQ9Q@mail.gmail.com>
Il 09/05/2013 10:54, liu ping fan ha scritto:
> On Thu, May 9, 2013 at 4:44 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote:
>>> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>>>
>>> Hosts threads which handle vring should have high MemoryListener priority
>>> than kvm. For currently code, take the following scenario:
>>> kvm_region_add() run earlier before vhost_region_add(), then in guest,
>>> vring's desc[i] can refer to addressX in the new region known by guest.
>>> But vhost does not know this new region yet, and the vring handler will
>>> fail.
>>>
>>> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>>
>> Is this seen in testing, or are you describing a theorecitical
>> scenario? Please make this clear in the commit log.
>>
> A theorecitical scenario. I think vcpu thread and vhost are async,
> so we need this method to sync.
But why should this matter for hostmem? It doesn't communicate in any
way with the hypervisor.
Paolo
prev parent reply other threads:[~2013-05-09 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 0:40 [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm Liu Ping Fan
2013-05-09 0:40 ` [Qemu-devel] [PATCH 2/2] mem: highlight the listener's priority as enum Liu Ping Fan
2013-05-09 8:31 ` Stefan Hajnoczi
2013-05-09 9:05 ` liu ping fan
2013-05-09 9:21 ` Peter Maydell
2013-05-09 9:30 ` liu ping fan
2013-05-09 8:30 ` [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm Stefan Hajnoczi
2013-05-09 9:00 ` liu ping fan
2013-05-09 15:26 ` Stefan Hajnoczi
2013-05-10 6:03 ` liu ping fan
2013-05-10 7:12 ` Stefan Hajnoczi
2013-05-10 9:04 ` liu ping fan
2013-05-09 8:44 ` Michael S. Tsirkin
2013-05-09 8:54 ` liu ping fan
2013-05-09 14:58 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BB984.10200@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).