From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UamcL-0001YV-MW for qemu-devel@nongnu.org; Fri, 10 May 2013 08:40:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UamcK-0007sD-7R for qemu-devel@nongnu.org; Fri, 10 May 2013 08:40:09 -0400 Received: from goliath.siemens.de ([192.35.17.28]:18934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UamcJ-0007pf-S9 for qemu-devel@nongnu.org; Fri, 10 May 2013 08:40:08 -0400 Message-ID: <518CEAA4.6090005@siemens.com> Date: Fri, 10 May 2013 14:40:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20130509163157.22536.68566.stgit@bling.home> In-Reply-To: <20130509163157.22536.68566.stgit@bling.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] pci-assign: MSI affinity support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: "qemu-devel@nongnu.org" , "mst@redhat.com" On 2013-05-09 18:35, Alex Williamson wrote: > I posted these about 6 months ago and Jan felt we should implement > MSI notifiers like we have for MSI-X. That still hasn't happened. Device assignments are the only currently known users - and you provide this feature, so... POWER does this nice configuration of MSI messages via a side channel. Not that it already fires the MSI-X notifiers properly, but a generic notifier based approach is the right way to abstract away the different modification channels (instead of encoding them at the consumer side like in your patches). Moreover, having different designs for MSI and MSI-X is just ugly. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux